Repository navigation
[mock-npm-registry] Stop npm packages from getting local copies of their exact-pinned dependencies - #16922
Conversation
|
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
There was a problem hiding this comment.
Superseded by the review of
11370fc7.
This review, of 2ff2c3c9
✅ Approved — No issues found: the local-version rename and manifest rewrite are correct, and both have tests.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🔒 Security: ✅ LGTM
No security concerns found in this test-only registry tooling.
📖 AGENTS.md: ✅ LGTM
No conflicts with the repository conventions.
📋 Code Quality: ✅ LGTM
No problems found in the changed code. rewriteManifest changes only the runtime-relevant dependency fields. It fails loudly on specifiers it can't rewrite safely. pnpm publish gets --ignore-scripts, which is correct because prepack already ran during pnpm pack.
⚡ Performance: ✅ LGTM
The extra pack, unpack and publish for each package runs once during setup, so the added cost is small.
📝 Documentation: ✅ LGTM
The README additions match the new behaviour.
Reviewed commit: 2ff2c3c9
There was a problem hiding this comment.
Superseded by the review of
257f2932.
This review, of 11370fc7
✅ Approved — No issues found. The local-version scheme and the manifest rewrite are correct, and both have tests.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🔒 Security: ✅ LGTM
No security concerns in this test-only registry tooling.
📖 AGENTS.md: ✅ LGTM
The change is consistent with the repository's conventions.
📋 Code Quality: ✅ LGTM
No issues found:
rewriteManifestchanges onlydependencies,optionalDependenciesandpeerDependencies. It throws on any non-exact specifier that points at a renamed local package.- The callers of
startMockNpmRegistryuseworkspace:*for local packages, so that strict check won't trip. restoreLatestTagalso runs for packages published under thelocaltag. It returns early on an upstream 404.--ignore-scriptsand--no-git-checkson publish are appropriate. The temporary directory is cleaned up infinally.- The tests cover the version scheme, the manifest rewrite, the rejection cases and the dist-tag behaviour.
⚡ Performance: ✅ LGTM
Each package gets one extra pack, unpack, rewrite and publish, and this runs once during registry setup. The added cost is small.
📝 Documentation: ✅ LGTM
The README additions match the new behaviour.
Reviewed commit: 11370fc7
11370fc to
2ff2c3c
Compare
2ff2c3c to
257f293
Compare
There was a problem hiding this comment.
✅ Approved — No issues found. The local-version scheme and the manifest rewrite are correct, and both have tests.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🔒 Security: ✅ LGTM
No security concerns in this test-only registry tooling.
📖 AGENTS.md: ✅ LGTM
The change is consistent with the repository's conventions.
📋 Code Quality: ✅ LGTM
No issues found:
rewriteManifestchanges onlydependencies,optionalDependenciesandpeerDependencies. It throws on any non-exact specifier that points at a renamed local package.- The callers of
startMockNpmRegistryuseworkspace:*for local packages, so that strict check won't trip. restoreLatestTagalso runs for packages published under thelocaltag. It returns early on an upstream 404.--ignore-scriptsand--no-git-checkson publish are appropriate. The temporary directory is cleaned up infinally.- The tests cover the version scheme, the manifest rewrite, the rejection cases and the dist-tag behaviour.
⚡ Performance: ✅ LGTM
Each package gets one extra pack, unpack, rewrite and publish, and this runs once during registry setup. The added cost is small.
📝 Documentation: ✅ LGTM
The README additions match the new behaviour.
Reviewed commit: 257f2932 — same changes as 11370fc7, so this is that commit's review (no new review was run; line numbers are as of 11370fc7)
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
[mock-npm-registry] Stop npm packages from getting local copies of their exact-pinned dependencies
Tests are failing in #16917 because the published
cfdependency is resolving its@cloudflare/configdependency to the local version. This PR fixes that. Once it's merged the RC stack should be rebased.A picture of a cute animal (not mandatory, but encouraged)