Skip to content

[vite-plugin] Detect v1 PR-description paths with git - #16940

Open
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16874from
codex/vite-v1-backport-16912
Open

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16874from
codex/vite-v1-backport-16912

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #16912 for Vite plugin v1.

A transient GitHub file-list API error can fail the PR-description validation job before it checks a v1 contribution. Pass an empty token to the pinned paths-filter action so it compares the checked-out merge commit against the PR base using git. Its implementation fetches missing history for shallow checkouts; this workflow already checks out the default merge commit.

The remaining v1 diff is two lines in .github/workflows/validate-pr-description.yml. The other upstream workflows were removed or no longer use paths-filter on v1, so they need no change. No package behavior changes or changeset are needed.

This PR extends the native GitHub backport stack #16900 after #16930. Follow the stack order for merging. The lower runtime and OAuth backports now consume published npm versions and pass build, all 58 checks and all eight test tasks. The stack preserves the updated remote-preview correction on #16899.

Validation: Node 22.22.1 / pnpm 10.33.0; workflow action pinning, formatting and git diff --check pass. The lower #16930 tree passes pnpm build, pnpm check, and pnpm test:ci, including 269 plugin tests. This PR's only remaining diff is the two-line workflow input change; no package code or dependencies differ from that validated tree. Reviewed the pinned action implementation to confirm empty-token git fallback on pull_request events. No GitHub Actions execution is claimed from local validation.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this changes only the existing action input; workflow action pinning and formatting pass, and GitHub CI exercises the filter when the stack reaches vite-plugin-v1.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is an internal v1 CI reliability fix.

Note

This is a contribution from an AI agent: Codex.


Devin Review

@petebacondarwin petebacondarwin added ci:no-changeset-required Skip pull request checks for a valid changeset ci:no-tests Skip pull request checks for tests labels Nov 15, 2026
@changeset-bot

changeset-bot Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c9704ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@edmundhung (verified author) and @petebacondarwin (latest qualifying pre-merge human ant-core approval, 2026-11-13T18:10:46Z), please check this Vite plugin v1 backport of #16912 and approve it if it looks good.

The v1 adaptation is only the two-line git-fallback input in the retained PR-description workflow; other upstream workflows were removed or no longer use paths-filter. Workflow pinning/formatting and the build pass. This is part of native stack #16900 after #16930; broader checks inherit the pending npm publication in #16929/#16930 (no new dependency pins or changeset here).

@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team November 15, 2026 14:04
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of c9704baf.

This review, of a5a13ed5

💬 Approved with comments — The change is a minimal, correct backport. One non-blocking note: a later step still uses the GitHub API, so the reliability fix is only partial.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

The empty token makes paths-filter use local git. The later Ana06/get-changed-files step still calls the GitHub API, so the transient-error fix is partial. This is informational.


Reviewed commit: a5a13ed5

@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16940

commit: c9704ba

@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16940

commit: c9704ba

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Approved with comments — The change is a minimal, correct backport. One non-blocking note: a later step still uses the GitHub API, so the reliability fix is only partial.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

The empty token makes paths-filter use local git. The later Ana06/get-changed-files step still calls the GitHub API, so the transient-error fix is partial. This is informational.


Reviewed commit: c9704baf — same changes as a5a13ed5, so this is that commit's review (no new review was run; line numbers are as of a5a13ed5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset ci:no-tests Skip pull request checks for tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants