Repository navigation
[vite-plugin] Detect v1 PR-description paths with git - #16940
petebacondarwin wants to merge 1 commit into
Conversation
|
|
@edmundhung (verified author) and @petebacondarwin (latest qualifying pre-merge human ant-core approval, 2026-11-13T18:10:46Z), please check this Vite plugin v1 backport of #16912 and approve it if it looks good. The v1 adaptation is only the two-line git-fallback input in the retained PR-description workflow; other upstream workflows were removed or no longer use paths-filter. Workflow pinning/formatting and the build pass. This is part of native stack #16900 after #16930; broader checks inherit the pending npm publication in #16929/#16930 (no new dependency pins or changeset here). |
|
Codeowners approval required for this PR:
|
There was a problem hiding this comment.
Superseded by the review of
c9704baf.
This review, of a5a13ed5
💬 Approved with comments — The change is a minimal, correct backport. One non-blocking note: a later step still uses the GitHub API, so the reliability fix is only partial.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code reviewer: ✅ LGTM
The empty token makes paths-filter use local git. The later Ana06/get-changed-files step still calls the GitHub API, so the transient-error fix is partial. This is informational.
Reviewed commit: a5a13ed5
a5a13ed to
c9704ba
Compare
commit: |
commit: |
There was a problem hiding this comment.
💬 Approved with comments — The change is a minimal, correct backport. One non-blocking note: a later step still uses the GitHub API, so the reliability fix is only partial.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code reviewer: ✅ LGTM
The empty token makes paths-filter use local git. The later Ana06/get-changed-files step still calls the GitHub API, so the transient-error fix is partial. This is informational.
Reviewed commit: c9704baf — same changes as a5a13ed5, so this is that commit's review (no new review was run; line numbers are as of a5a13ed5)
Backport of #16912 for Vite plugin v1.
A transient GitHub file-list API error can fail the PR-description validation job before it checks a v1 contribution. Pass an empty token to the pinned paths-filter action so it compares the checked-out merge commit against the PR base using git. Its implementation fetches missing history for shallow checkouts; this workflow already checks out the default merge commit.
The remaining v1 diff is two lines in
.github/workflows/validate-pr-description.yml. The other upstream workflows were removed or no longer use paths-filter on v1, so they need no change. No package behavior changes or changeset are needed.This PR extends the native GitHub backport stack #16900 after #16930. Follow the stack order for merging. The lower runtime and OAuth backports now consume published npm versions and pass build, all 58 checks and all eight test tasks. The stack preserves the updated remote-preview correction on #16899.
Validation: Node 22.22.1 / pnpm 10.33.0; workflow action pinning, formatting and
git diff --checkpass. The lower #16930 tree passespnpm build,pnpm check, andpnpm test:ci, including 269 plugin tests. This PR's only remaining diff is the two-line workflow input change; no package code or dependencies differ from that validated tree. Reviewed the pinned action implementation to confirm empty-token git fallback on pull_request events. No GitHub Actions execution is claimed from local validation.Note
This is a contribution from an AI agent: Codex.