Skip to content

V10.8.0/sonar new code acceptance do not merge - #176

Closed
gimlichael wants to merge 1 commit into
mainfrom
v10.8.0/sonar-new-code-acceptance-do-not-merge
Closed

gimlichael wants to merge 1 commit into
mainfrom
v10.8.0/sonar-new-code-acceptance-do-not-merge

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request validates Sonar PR New Code coverage using the normalized coverage mode already configured on main. It is disposable acceptance evidence only: do not merge; after a successful acceptance, close the PR and delete its branch without merging.

Disposable coverage acceptance:

  • Introduce one behavior-preserving condition on one executable line in an existing private byte-pattern helper, without changing public APIs.
  • Exercise both condition outcomes through the existing public facade with two deterministic test cases.
  • Leave Sonar actions/workflows, Codecov configuration and raw TestResults/OpenCover inputs, release/deploy workflows, and canonical Sonar main unchanged.
  • Verify actual PR analysis against main exposes 100% New Code line, condition, and combined coverage, with exactly one generic Sonar coverage report parsed and zero raw OpenCover reports parsed.
  • Local verification passed: Release builds across all source target frameworks; 2,330 Core test executions across net10.0, net9.0, and net48; changed-line and both-path coverage confirmed in net9/net10 Release and net10 Debug reports. Local net48 tests passed, but coverage of this helper was not established in its local report.

Introduce one behavior-preserving private condition and exercise both outcomes so this disposable PR can verify normalized New Code line and condition coverage against main. Do not merge.

Generated with Codebuff 🤖
Co-Authored-By: Codebuff <noreply@codebuff.com>
@gimlichael gimlichael self-assigned this Oct 6, 2026
@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes byte-matching logic in a utility function.

The code changes appear safe, but this disposable acceptance PR is explicitly not intended to be merged.

Summary

The PR replaces a byte-comparison expression with an equivalent condition and adds two public-facade test cases for its match and mismatch outcomes.

  • No behavioral change or actionable review issue was identified.
  • The changes are limited to the helper and its tests.

Reviews (1) · Last reviewed commit: "✅ validate normalized Sonar PR coverage ..."

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.77%. Comparing base (33e6e75) to head (40fde90).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files         608      608           
  Lines       19273    19273           
  Branches     1865     1866    +1     
=======================================
  Hits        18073    18073           
  Misses       1172     1172           
  Partials       28       28           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gimlichael gimlichael closed this Oct 6, 2026
@gimlichael
gimlichael deleted the v10.8.0/sonar-new-code-acceptance-do-not-merge branch October 6, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants