Skip to content

V10.8.0/sonar new code acceptance do not merge #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gimlichael wants to merge 1 commit into from
Closed

V10.8.0/sonar new code acceptance do not merge #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cuemon.Core/Eradicate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ private static bool HasMatch(int index, byte[] bytes, byte[] trailingBytes)
var match = true;
for (var i = 0; i < trailingBytes.Length; i++)
{
match &= trailingBytes[i] == bytes[index - i];
if (trailingBytes[i] != bytes[index - i]) { match = false; }
}
return match;
}
Expand Down
10 changes: 10 additions & 0 deletions test/Cuemon.Core.Tests/EradicateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ public void TrailingBytes_WithRepeatedTrailingPattern_RemovesAllTrailingPatterns
Assert.Equal(new byte[] { 1, 2 }, sut);
}

[Theory]
[InlineData(new byte[] { 1, 2, 3 }, new byte[] { 1, 2 })]
[InlineData(new byte[] { 1, 2, 4 }, new byte[] { 1, 2, 4 })]
public void TrailingBytes_ShouldReturnExpectedBytes_WhenTrailingByteMatchesOrDiffers(byte[] bytes, byte[] expected)
{
var sut = Eradicate.TrailingBytes(bytes, new byte[] { 3 });

Assert.Equal(expected, sut);
}

[Fact]
public void TrailingBytes_WithoutTrailingPattern_ReturnsSameInstance()
{
Expand Down
Loading