fix: error when --pipeline-name matches no pipeline [closes CCS-34] - #927
Draft
openswe-task-force[bot] wants to merge 1 commit into
Draft
openswe-task-force[bot] wants to merge 1 commit into
openswe-task-force[bot] wants to merge 1 commit into
Conversation
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
codefresh get builds --pipeline-name <unknown>silently returned every build: the empty-result check tested the SDK response envelope (_.isEmpty(pipelines)), which is never empty, sorequestOptions.pipelinewas never set and the filter was dropped. Now the check is ondocs, and an unmatched name always throwsCannot find any builds with these pipelines names.Release Note
codefresh get builds --pipeline-namenow fails with a clear error when the pipeline name does not exist, instead of silently returning all builds.Test Plan
codefresh get builds --pipeline-name does/not-existerrors out; a valid name still filters correctly.Made by Open SWE
Security Report — codefresh/cli
Note
Compared security scans:
Current image:
quay.io/codefresh/cli:open-swepipeline-name-not-found@sha256:4dc24d55d28cbc4a6755fae1292784a77498be784b4f0b385d95ddabf099b4d8
Baseline:
quay.io/codefresh/cli:master@sha256:0f54336751469820235db1df602cd29ce56c6d2dace33b552fb53d7958f91f65
Fixed CVEs: 0
Fixed issues: 0