Skip to content

fix: error when --pipeline-name matches no pipeline [closes CCS-34] #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
openswe-task-force wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: error when --pipeline-name matches no pipeline [closes CCS-34] #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/interface/cli/commands/workflow/get.cmd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ const command = new Command({
from,
to,
} = argv;
const pipelineNames = !_.isArray(argv['pipeline-name']) ? [(argv['pipeline-name'])] : argv['pipeline-name'];
const pipelineIds = !_.isArray(argv['pipeline-id']) ? [(argv['pipeline-id'])] : argv['pipeline-id'];
const pipelineNames = _.compact(!_.isArray(argv['pipeline-name']) ? [(argv['pipeline-name'])] : argv['pipeline-name']);
const pipelineIds = _.compact(!_.isArray(argv['pipeline-id']) ? [(argv['pipeline-id'])] : argv['pipeline-id']);

const requestOptions = {
limit,
Expand All @@ -140,14 +140,14 @@ const command = new Command({
const pipelines = await sdk.pipelines.list({
id: pipelineNames,
});
if (!_.isEmpty(pipelines)) {
_.forEach(pipelines.docs, (currPipeline) => {
pipelineIds.push(currPipeline.metadata.id);
});
requestOptions.pipeline = pipelineIds;
} else if (_.isEmpty(pipelineIds)) {
const pipelineDocs = _.get(pipelines, 'docs');
if (_.isEmpty(pipelineDocs)) {
throw new CFError('Cannot find any builds with these pipelines names');
}
_.forEach(pipelineDocs, (currPipeline) => {
pipelineIds.push(currPipeline.metadata.id);
});
requestOptions.pipeline = pipelineIds;
} else if (!_.isEmpty(pipelineIds)) {
requestOptions.pipeline = pipelineIds;
}
Expand Down
6 changes: 6 additions & 0 deletions lib/interface/cli/commands/workflow/workflow.sdk.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ describe('workflow commands', () => {
await verifyResponsesReturned(responses); // eslint-disable-line
});

it('should throw when pipeline name does not match any pipeline', async () => {
const argv = { 'pipeline-name': 'does-not-exist' };
request.__setResponse({ statusCode: 200, body: { docs: [] } });
await expect(getCmd.handler(argv)).rejects.toThrow('Cannot find any builds with these pipelines names');
});

it('should handle getting all', async () => {
const argv = { 'pipeline-name': [] };
const response = {
Expand Down