Repository navigation
fix(server): dictation loads its native packages in the single executable - #47
Merged
Merged
Conversation
…able build-exe refused collin/main: localDictation imported koffi and transcribe-cpp with import(), which a Node single-executable cannot resolve. Both now load through require from disk, as speech/native.ts already does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node apps/server/scripts/cli.ts build-exefailed on collin/main withServerCliExecutableImportError: … imports file-backed packages that a single-executable cannot resolve: koffi, transcribe-cpp, so the fork release could not build the Linux CLI archive added in #46.localDictation.tsnow loads both packages throughrequirefrom disk, the wayspeech/native.tsalready loads transcribe-cpp.Checked:
build-exesucceeds on this branch and the executable starts;check:changedpasses except the React Compiler coverage test forDictationHistoryDialog.tsx, a file this PR does not touch. Not checked: dictation itself in the desktop app.Claude Fable 5.2, Claude Code
🤖 Generated with Claude Code