Repository navigation
fix(secret-scrub): redact bare-KEY names in JSON object and text paths - #1471
Merged
TheGreatAxios merged 3 commits intoOct 17, 2026
Conversation
Provider-prefixed keys carry no token or secret marker, so the JSON classifiers need their own KEY boundary; the required prefix keeps a field named exactly key and MONKEY-style words readable.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
Bare *_key names are redacted in JSON and query strings. The value-class change also leaks the tail of older password, api_key, and token secrets.
Findings
src/plugins/tool-result-secret-scrub.ts:21— the query value now stops at'or".?password=p'LEAKTAIL&format=jsonkeepsLEAKTAIL. The same tail survives forapi_keyandtoken. A quote inside the secret should not end the match.src/plugins/tool-result-secret-scrub.ts:24—[^"]+_keyredactspartition_key,sort_key,prompt_cache_key, andcache_key, including numbers and arrays. That is wider than a credential name.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Not Ready
and removed
Triage: Ready
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Query secrets keep the characters after a quote. partition_key, sort_key, and cache_key stay readable. OPENAI_KEY and api_key still redact.
No findings.
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes CL-10761