Skip to content

feat: send chatgpt-account-id from the source's quirks - #32

Merged
TheGreatAxios merged 1 commit into
mainfrom
feat/account-id-quirk
Oct 29, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
feat/account-id-quirk

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Closes #31

What changed

  • CodexQuirks accepts an optional accountId (visible ASCII only), sent as the chatgpt-account-id static header.
  • providerOptions[CODEX_ACCOUNT_ID_OPTION] still overrides it per call.
  • README documents the quirk as the path for Interchange catalog sources, and that it binds a source to one ChatGPT account. Quirks/adapter JSDoc and AGENTS.md layout mention the field.

Verification

  • bun run check (typecheck, lint, format, 19 unit tests) passes.
  • New tests pin the header from the quirk, the option override, and rejection (CodexQuirksError) of a header-splitting value.
  • Independent review findings addressed (stricter value check, docs, test matcher).

An Interchange catalog source carries no providerOptions, so a deployment can now state the account in CodexQuirks.accountId. A per-call option still overrides it.
@corbits-triage

corbits-triage Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve, request review.

@TheGreatAxios
TheGreatAxios merged commit f9f95b1 into main Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send chatgpt-account-id from the source's quirks

1 participant