Skip to content

fix(csv-table): draw the selection outline as edge strips #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Nov 1, 2026
Merged

fix(csv-table): draw the selection outline as edge strips #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions e2e/stories-a11y.known.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,5 @@
"primitives-avatar--orbit (dark): color-contrast-unmeasured": "The orbit ring is positioned over the initials and hollowed by a mask; hit-testing finds its whole box and the sampler takes a mask as opaque, so the ground under the initials cannot be read.",
"primitives-avatar--orbit (light): color-contrast-unmeasured": "The orbit ring is positioned over the initials and hollowed by a mask; hit-testing finds its whole box and the sampler takes a mask as opaque, so the ground under the initials cannot be read.",
"primitives-avatar--stack-with-status (dark): color-contrast-unmeasured": "The orbit ring is positioned over the initials and hollowed by a mask; hit-testing finds its whole box and the sampler takes a mask as opaque, so the ground under the initials cannot be read.",
"primitives-avatar--stack-with-status (light): color-contrast-unmeasured": "The orbit ring is positioned over the initials and hollowed by a mask; hit-testing finds its whole box and the sampler takes a mask as opaque, so the ground under the initials cannot be read.",
"primitives-csv-table--resized-column (dark): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read.",
"primitives-csv-table--resized-column (light): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read.",
"primitives-csv-table--selection (dark): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read.",
"primitives-csv-table--selection (light): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read.",
"primitives-csv-table--sheets (dark): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read.",
"primitives-csv-table--sheets (light): color-contrast-unmeasured": "The selected range's outline is one box laid over its cells that paints only a border; hit-testing finds that box over the selected text and the sampler cannot follow a box that paints its edges alone, so the ground under the selected cells cannot be read."
"primitives-avatar--stack-with-status (light): color-contrast-unmeasured": "The orbit ring is positioned over the initials and hollowed by a mask; hit-testing finds its whole box and the sampler takes a mask as opaque, so the ground under the initials cannot be read."
}
13 changes: 10 additions & 3 deletions src/ui/csv-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,9 @@ function CsvGrid({
});

// One outline around the whole range, drawn over the cells rather than as
// per-cell borders, which would also outline every inner edge.
// per-cell borders, which would also outline every inner edge. The box is
// invisible and only its four edge strips paint, so hit-testing the selected
// cells' text reaches the cells, not the box.
useLayoutEffect(() => {
const box = overlay.current;
const frame = box?.parentElement;
Expand Down Expand Up @@ -1438,8 +1440,13 @@ function CsvGrid({
ref={overlay}
hidden
aria-hidden
className="pointer-events-none absolute z-1 border-2 border-ring"
/>
className="pointer-events-none invisible absolute z-1 *:visible *:absolute *:bg-ring"
>
<div className="inset-x-0 top-0 h-0.5" />
<div className="inset-y-0 right-0 w-0.5" />
<div className="inset-x-0 bottom-0 h-0.5" />
<div className="inset-y-0 left-0 w-0.5" />
</div>
</div>
{view.length === 0 ? (
<p className="px-3 py-6 text-center text-sm text-muted-foreground">
Expand Down
Loading