Skip to content

fix(csv-table): draw the selection outline as edge strips - #161

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11916-draw-the-csvtable-selection-outline-as-edge-strips-so
Nov 1, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11916-draw-the-csvtable-selection-outline-as-edge-strips-so

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11916. Stacked on #160.

What changed

  • The selection outline box is invisible and paints only four 2px bg-ring edge strips, the same place, thickness and colour as the old border-2. Hit-testing over the selected cells' text now reaches the cells.
  • The six primitives-csv-table--* contrast-unmeasured entries are removed from the a11y known list.

Verified

  • CSV-table a11y sweep passes in light and dark with no CSV entries. With the old outline and the entries removed, it fails with exactly those six results.
  • Selection story screenshots are byte-identical before and after, light and dark.
  • bun run check (878 pass) and bun run build.

@linear-code

linear-code Bot commented Nov 1, 2026

Copy link
Copy Markdown

CL-11916

@corbits-triage

corbits-triage Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Stacked on #160: only this pull request's own changes were checked.

Triage will approve.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11915-show-csvtable-sheets-as-tabs-for-multi-sheet-workbooks branch from 174436a to 5578e5c Compare November 1, 2026 02:52
@TheGreatAxios
TheGreatAxios force-pushed the cl-11916-draw-the-csvtable-selection-outline-as-edge-strips-so branch from 9027118 to c9936cf Compare November 1, 2026 02:53
@TheGreatAxios
TheGreatAxios changed the base branch from cl-11915-show-csvtable-sheets-as-tabs-for-multi-sheet-workbooks to main November 1, 2026 02:53
@TheGreatAxios
TheGreatAxios merged commit 2e5b8f5 into main Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant