Repository navigation
Conversation
The ops role publishes path-like parameters that a model can set. Resolve every kept path under the work tree of the server process, remove the output options of ai_ast_graph and k8s_security_stream, and audit every published tool for an unconfined parameter, a short reason or a stale entry.
dan-petty
marked this pull request as ready for review
November 4, 2026 14:44
Owner
Author
Evaluation: not selectedThis implementation is strong: it uses the work tree root, resolves each kept argument to an absolute path, audits the full catalogue, and all CI checks pass. I compared it with #3467 against issue #3300. Blocking differences:
Minor: the audit lives in product code ( No code change is needed on this pull request for the evaluation itself. #3467 is selected and refined in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ops role publishes path-like parameters that a model can set. Every kept path now resolves under the work tree of the server process through safe_resolve_subpath, the output options of ai_ast_graph and k8s_security_stream are gone, and a new audit fails on an unconfined parameter, a short reason or a stale entry. The #3236 plan is folded in because its tables were unbuilt.
Closes #3300
Change:
openspec/changes/archive/2026-11-04-3300-the-ops-role-publishes-60-tools-with/