Repository navigation
fix(mcp): confine every MCP path parameter to the work tree - #3467
Merged
Merged
Conversation
dan-petty
marked this pull request as ready for review
November 4, 2026 14:43
Owner
Author
Evaluation: selected and refinedSelected over #3466 for issue #3300. Both branches pass the full CI checks, the MCP suite and the audit. Why this one wins:
Refinement in
Verification on the refined head:
|
dan-petty
pushed a commit
that referenced
this pull request
Nov 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.55.4](v0.55.3...v0.55.4) (2026-11-04) ### Bug Fixes * **mcp:** confine every MCP path parameter to the work tree ([#3467](#3467)) ([e5df741](e5df741)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: dan-petty-release[bot] <346998822+dan-petty-release[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
opsrole published 70 path-like parameters across 61 tools that a model could set. This change drops the write paths and the certificate, SSH key and template options that have a configured store. It confines every remaining read path withsafe_resolve_subpathunder the server work tree, refuses an escape before the command starts, and records each non-file value with a reason. A new audit covers every published tool, so a new path parameter cannot escape the rule in silence.Closes #3300
Change:
openspec/changes/archive/2026-11-04-3300-the-ops-role-publishes-60-tools/