Skip to content

test(roadmap): cover a refused delivery title before the write - #3472

Closed
dan-petty wants to merge 2 commits into
mainfrom
test/3368-cover-a-refused-delivery-title
Closed

dan-petty wants to merge 2 commits into
mainfrom
test/3368-cover-a-refused-delivery-title

Conversation

@dan-petty

Copy link
Copy Markdown
Owner

Two tests hold the guard that _delivery_title runs before the job writes a pull request title.

  • A Staged item whose issue title is wip(cli): add a flag stops at the pull request step and writes no title.
  • A Planned item whose title loses its type after the plan stops before the first push, so origin holds no branch and no draft exists.

Closes #3368

Change: openspec/changes/archive/2026-11-04-3368-stop-a-delivery-title-that-the/

@dan-petty dan-petty added type/test Unit, integration, invariant, or benchmark test authoring scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them labels Nov 4, 2026
@dan-petty
dan-petty marked this pull request as ready for review November 4, 2026 16:31
@dan-petty

Copy link
Copy Markdown
Owner Author

Evaluation for #3368 - not selected

Good implementation. It edits the real issue title for the staged case and the target title after the plan for the planned case. It therefore exercises the production guard without a patch.

Why #3474 was selected instead:

No defect found. CI passes. Close in favor of #3474 to keep one pull request for #3368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them type/test Unit, integration, invariant, or benchmark test authoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roadmap): stop a delivery title that the check refuses

1 participant