dan-petty · Nov 4, 2026 · Nov 4, 2026 · Nov 4, 2026
@@ -3,7 +3,7 @@
 ## Decisions
 
 - **Put both tests in `tests/roadmap/test_roadmap_implement_job.py`, beside the #3319 test.** The guard is one function, `_delivery_title`, and its tests belong in the module that already holds the refused-title test, so a reader sees every case together and no new module mirrors one helper.
-- **Use `planned_world` for the first-push case and assert that `origin` holds no branch, not that the job deletes one.** `_publish` calls `_delivery_title` before `_push`, so a refused title stops the item before the branch reaches `origin`; a deletion assertion would describe code that no longer exists.
+- **Use `planned_world` for the first-push case and edit the target title after the plan.** The plan judge already refuses a Planned item whose issue title has no type (`stage_left_title_type`), so the test keeps a valid title at plan time and replaces the title in the planned target. This holds the `_publish` guard itself: the item stops before the push and `origin` holds no branch, which a deletion assertion would not describe.
 - **Set `skip_specs: true` and write no spec delta.** The change adds tests for behavior that `openspec/specs/roadmap-implement-job/spec.md` already states in the requirement `The pull request that delivers the code has the type of the issue`, and a test changes no behavior that a consumer observes.
 
 ## Rejected alternatives

@@ -7,7 +7,7 @@ The implement job must stop an item whose delivery title the pull request form r
 ## What Changes
 
 - Add a test to `tests/roadmap/test_roadmap_implement_job.py` for an issue title `wip(cli): add a flag`, whose type `wip` the project does not declare: the job stops the item and writes no pull request title.
-- Add a test for a Planned item whose delivery title has no type: the job stops before `_publish` pushes the branch, so `origin` holds no branch and no draft pull request exists.
+- Add a test for a Planned item whose delivery title has no type, with the title edited in the planned target because the plan judge already refuses such an issue title: the job stops before `_publish` pushes the branch, so `origin` holds no branch and no draft pull request exists.
 - The change alters no behavior that a consumer observes, because it adds tests for behavior that `openspec/specs/roadmap-implement-job/spec.md` already states. It has no spec delta and sets `skip_specs: true`.
 - The change fits one pull request.
 

@@ -4,9 +4,9 @@
 
 Reads: `src/devops_cli/roadmap/implement_run.py`, `src/devops_cli/roadmap/pull_form.py`, `tests/roadmap/test_roadmap_implement_job.py`. Changes: `tests/roadmap/test_roadmap_implement_job.py`.
 
-- [ ] 1.1 Add a test for an issue title `wip(cli): add a flag`, whose type the project does not declare, and assert the job stops the item and writes no pull request title
+- [x] 1.1 Add a test for an issue title `wip(cli): add a flag`, whose type the project does not declare, and assert the job stops the item and writes no pull request title
   - Verification: `uv run devops ci test tests/roadmap/test_roadmap_implement_job.py`
-- [ ] 1.2 Add a test for a Planned item whose delivery title has no type, and assert the job stops before `_publish` pushes, so `origin` holds no branch and no draft pull request exists
+- [x] 1.2 Add a test for a Planned item whose delivery title has no type, and assert the job stops before `_publish` pushes, so `origin` holds no branch and no draft pull request exists
   - Verification: `uv run devops ci test tests/roadmap/test_roadmap_implement_job.py`
 
 ## Workflow follow-up

@@ -12,6 +12,7 @@
 import shutil
 import subprocess
 from collections.abc import Callable
+from dataclasses import replace
 from pathlib import Path
 
 import pytest
@@ -283,6 +284,63 @@ def test_a_title_that_the_check_refuses_stops_the_item_before_the_job_writes_it(
     assert "not in the form" in job_world.issue_comments()[0]
 
 
+def test_a_title_with_a_type_that_the_project_does_not_declare_stops_the_item(
+    job_world: JobWorld,
+) -> None:
+    """A person may edit the issue title after staging (#3368). The implement job reads the title
+    again when it publishes, and a type the project does not declare fails the check
+    `Semantic PR title`, so the job stops before it writes the title."""
+    issue = job_world.store._roadmap.issues[1]
+    job_world.store._roadmap.issues[1] = issue.model_copy(update={"title": "wip(cli): add a flag"})
+
+    applied = job_world.run(two_groups())
+
+    status, record = _item(job_world)
+    assert (applied.stopped, status, record.get("implement.stopped")) == (
+        (1,),
+        "Blocked",
+        "pull request",
+    )
+    assert job_world.sent("PATCH", f"pulls/{PULL}") == []
+    comment = job_world.issue_comments()[0]
+    assert "The type `wip` is not a type of the project" in comment
+    assert "The title is `wip(cli): add a flag`." in comment
+
+
+def test_a_planned_item_with_a_title_that_has_no_type_stops_before_the_first_push(
+    planned_world: JobWorld,
+) -> None:
+    """A person may edit the issue title after the plan reads it (#3368). The delivery title of a
+    Planned item must pass the check before the first push, so a title with no Conventional Commit
+    type stops the item before any branch reaches `origin` and no draft pull request exists."""
+    plan = planned_world.plan()
+    (target,) = plan.selected
+    edited = replace(
+        plan,
+        selected=(replace(target, item=target.item.model_copy(update={"title": "Add a flag"})),),
+    )
+
+    applied = apply_implement(
+        planned_world.store,
+        edited,
+        source=planned_world.repo.clone,
+        model=two_groups().model(),
+        window=WINDOW,
+    )
+
+    status, record = _item(planned_world)
+    assert (applied.stopped, status, record.get("implement.stopped")) == (
+        (1,),
+        "Blocked",
+        "push",
+    )
+    assert planned_world.repo.origin_git("branch", "--list", BRANCH) == ""
+    assert not any(request.method == "POST" for request in planned_world.api.sent)
+    comment = planned_world.issue_comments()[0]
+    assert "not in the form" in comment
+    assert "The title is `Add a flag: `." in comment
+
+
 def test_the_changes_of_the_archive_and_the_documents_are_in_the_pushed_tree(
     job_world: JobWorld,
 ) -> None: