Skip to content

test(roadmap): hold the delivery title guard before the write (#3368) - #3474

Merged
dan-petty merged 2 commits into
mainfrom
test/3368-hold-the-delivery-title-guard
Nov 4, 2026
Merged

dan-petty merged 2 commits into
mainfrom
test/3368-hold-the-delivery-title-guard

Conversation

@dan-petty

@dan-petty dan-petty commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

The implement job refuses a delivery title that the pull request form rejects. Add regression tests for an issue title edited after staging: an undeclared Conventional Commit type, and a title with no type that stops a Planned item before the first push. Both tests assert that the stop message names the problem and the refused title.

Closes #3368

Change: openspec/changes/archive/2026-11-04-3368-stop-a-delivery-title-that-the/

@dan-petty dan-petty added type/test Unit, integration, invariant, or benchmark test authoring scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them labels Nov 4, 2026
@dan-petty
dan-petty marked this pull request as ready for review November 4, 2026 16:38
@dan-petty

Copy link
Copy Markdown
Owner Author

Evaluation for #3368 - selected

This pull request is the selected implementation.

  • It derives the title through the real delivery_title path. The staged case edits the issue title in the store. The planned case edits the target after the plan reads it. Both cases exercise the production guard.
  • Its assertions are the strongest of the three. The undeclared-type case checks the exact problem text. The planned case checks that no API POST occurs and that origin holds no branch.
  • The proposal and design state why the planned case edits the target title: the plan judge already refuses a no-type issue title.

Refinement pushed in eb5ec8ce. Both tests now assert that the stop message names the refused title, as the acceptance criteria require. uv run devops ci test tests/roadmap/test_roadmap_implement_job.py passes (61 tests).

@dan-petty
dan-petty merged commit 46cf288 into main Nov 4, 2026
19 checks passed
@dan-petty
dan-petty deleted the test/3368-hold-the-delivery-title-guard branch November 4, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them type/test Unit, integration, invariant, or benchmark test authoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roadmap): stop a delivery title that the check refuses

1 participant