Skip to content

Make base ISO downloads survive mirror moves and dead mirror hosts #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marketen merged 1 commit into from
Oct 8, 2026
Merged

Make base ISO downloads survive mirror moves and dead mirror hosts #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions iso/scripts/common_iso_generation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,34 @@ WORKDIR="/usr/src/app"
ISO_BUILD_PATH="${WORKDIR}/dappnode-iso"
DAPPNODE_ISO_PREFIX="Dappnode-"

# Usage: download_iso <path> <name> <url> [fallback_url...]
# URLs are tried in order, which covers mirrors that move older releases elsewhere.
download_iso() {
local iso_path=$1
local iso_name=$2
local iso_url=$3
shift 2

echo "[INFO] Downloading base ISO image: ${iso_name}..."
if [ ! -f "${iso_path}" ]; then
wget "${iso_url}" -O "${iso_path}"
if [ -f "${iso_path}" ]; then
echo "[INFO] Download complete!"
return 0
fi
echo "[INFO] Download complete!"

local iso_url
for iso_url in "$@"; do
# Unlike busybox wget, curl moves on to the next address when a mirror
# host resolves to several and one of them is down.
if curl -fsSL --retry 3 --retry-connrefused --connect-timeout 30 -o "${iso_path}" "${iso_url}"; then
echo "[INFO] Download complete!"
return 0
fi
# A failed download leaves a partial file behind, which would be reused on the next run
rm -f "${iso_path}"
echo "[WARN] Could not download ${iso_url}"
done

echo "[ERROR] Could not download ${iso_name} from any known location"
exit 1
}

verify_download() {
Expand Down
7 changes: 5 additions & 2 deletions iso/scripts/generate_dappnode_iso_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ BASE_ISO_NAME="debian-13.5.0-amd64-netinst.iso"
BASE_ISO_VERSION="${BASE_ISO_NAME#debian-}"
BASE_ISO_VERSION="${BASE_ISO_VERSION%-amd64-netinst.iso}"
BASE_ISO_PATH="/images/${BASE_ISO_NAME}"
BASE_ISO_URL="https://cdimage.debian.org/mirror/cdimage/archive/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
# Debian serves the newest point release from debian-cd/ and only moves it to the
# archive once it is superseded, so try both.
BASE_ISO_URL="https://cdimage.debian.org/debian-cd/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
BASE_ISO_ARCHIVE_URL="https://cdimage.debian.org/mirror/cdimage/archive/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
BASE_ISO_SHASUM="95838884f5ea6c82421dfe6baaa5a639dbbe6756c1e380f9fe7a7cb0c1949d2a ${BASE_ISO_PATH}"

DAPPNODE_ISO_NAME="${DAPPNODE_ISO_PREFIX}${BASE_ISO_NAME}"
Expand Down Expand Up @@ -87,7 +90,7 @@ generate_debian_iso() {
-isohybrid-gpt-basdat -o "${iso_output_path}" ${iso_build_path}
}

download_iso "${BASE_ISO_PATH}" "${BASE_ISO_NAME}" "${BASE_ISO_URL}"
download_iso "${BASE_ISO_PATH}" "${BASE_ISO_NAME}" "${BASE_ISO_URL}" "${BASE_ISO_ARCHIVE_URL}"
verify_download "${BASE_ISO_PATH}" "${BASE_ISO_SHASUM}"
clean_old_files "${ISO_BUILD_PATH}" "${DAPPNODE_ISO_PREFIX}"
extract_iso "${BASE_ISO_PATH}" "${ISO_BUILD_PATH}"
Expand Down
Loading