Repository navigation
php: corpus targets live in php/private/quality (part of #12606) - #12694
Merged
Merged
Conversation
8 tasks
Collaborator
Author
|
Merge train: dropped, squash onto current main conflicts in php/private/BUILD.bazel (source file, needs manual rebase) 🤖 Generated with Claude Code |
…ures loads in rule-set files (part of #12606) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
TrapsterDK
force-pushed
the
php-core-loads
branch
from
November 14, 2026 04:36
db346b5 to
a06726a
Compare
Collaborator
Author
|
Fixed: rebased onto origin/main; kept main's module_srcs filegroup in php/private/BUILD.bazel and dropped corpus_starlark (now in php/private/quality). //php/... --build_tests_only and //tools/ci:rule_set_loads_test pass; conformance subject tests are skipped as incompatible on this platform (no exec_launcher error seen). No labels on the PR, so no stale review. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12606. Removes the core/quality:fixtures.bzl loads from php/BUILD.bazel, php/private/{,lock,toolchain}/BUILD.bazel; corpus targets move to php/private/quality. Allowlist shrinks.
Remaining: php/private/defs.bzl core loads (entry, fuzz_bench, platform_support, wrapper, quality/sources), php/private/BUILD.bazel conformance/defs/entry loads, php.bzl cli/launcher, then composer hub, launcher, mirror, in-tree module, extraction, BCR.
Tested: //php/... --build_tests_only and //tools/ci:rule_set_loads_test pass except //php/tests/conformance:{pass,fail}_test, which fail to build ('cli/launcher/exec_launcher is not a file', files untouched). Nested-Bazel and consumer tests not run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD