php: corpus targets live in php/private/quality (part of #12606)

php/BUILD.bazel

@@ -1,29 +1,12 @@
-load("@rules_dx//core/quality:fixtures.bzl", "real_source_target")
-
 exports_files([
+    "BUILD.bazel",
     "README.md",
     "defs.bzl",
     "extensions.bzl",
     "lang.json",
     "pins.json",
 ])
 
-real_source_target(
-    name = "corpus_markdown",
-    markdown_srcs = ["README.md"],
-    tags = ["corpus"],
-)
-
-real_source_target(
-    name = "corpus_starlark",
-    starlark_srcs = [
-        "BUILD.bazel",
-        "defs.bzl",
-        "extensions.bzl",
-    ],
-    tags = ["corpus"],
-)
-
 filegroup(
     name = "module_srcs",
     srcs = glob([

php/private/BUILD.bazel

@@ -2,7 +2,6 @@
 load("//core:conformance.bzl", "dx_wrapper_contract_tests")
 load("//core:defs.bzl", "expect_contains", "expect_equal", "expect_true", "label_string")
 load("//core:entry.bzl", "dx_entry_quality_srcs", "dx_infer_main", "dx_main_candidates")
-load("//core/quality:fixtures.bzl", "real_source_target")
 load(":defs.bzl", "PHP_COMPATIBLE_WITH", "PHP_DEFERRED_SKIP_TAGS", "PHP_SOURCE_SPECS")
 load(":php.bzl", "PHP_SOURCE_EXTS", "autoloader_suffix", "coverage_descriptor", "env_flag", "ini_flags", "launcher_descriptor", "lit", "rf", "rf_prefixed", "runfiles_path")
 
@@ -13,6 +12,7 @@ package(default_visibility = [
 ])
 
 exports_files([
+    "BUILD.bazel",
     "BenchTest.php",
     "defs.bzl",
     "patches/pcov_user_opcode_handlers.patch",
@@ -208,18 +208,6 @@ dx_wrapper_contract_tests(
     file_classes = ["php"],
 )
 
-real_source_target(
-    name = "corpus_starlark",
-    starlark_srcs = [
-        "BUILD.bazel",
-        "defs.bzl",
-        "php.bzl",
-        "providers.bzl",
-        "pcov.BUILD.bazel",
-    ],
-    tags = ["corpus"],
-)
-
 filegroup(
     name = "module_srcs",
     srcs = glob([

php/private/lock/BUILD.bazel

@@ -1,20 +1,7 @@
-load("//core/quality:fixtures.bzl", "real_source_target")
-
 package(default_visibility = ["//visibility:private"])
 
-real_source_target(
-    name = "corpus_starlark",
-    starlark_srcs = [
-        "BUILD.bazel",
-        "hub.bzl",
-        "repo.bzl",
-    ],
-    tags = ["corpus"],
-    visibility = ["//tools/ci:__pkg__"],
-)
-
 exports_files(
-    ["hub.bzl"],
+    ["BUILD.bazel", "hub.bzl", "repo.bzl"],
     visibility = ["//:__subpackages__"],
 )
 

php/private/quality/BUILD.bazel

@@ -12,12 +12,34 @@ exports_files([
     "php_tools.bzl",
 ])
 
+real_source_target(
+    name = "corpus_markdown",
+    markdown_srcs = ["//php:README.md"],
+    tags = ["corpus"],
+)
+
 real_source_target(
     name = "corpus_starlark",
     starlark_srcs = [
         "BUILD.bazel",
         "php.bzl",
         "php_tools.bzl",
+        "//php:BUILD.bazel",
+        "//php:defs.bzl",
+        "//php:extensions.bzl",
+        "//php/private:BUILD.bazel",
+        "//php/private:defs.bzl",
+        "//php/private:pcov.BUILD.bazel",
+        "//php/private:php.bzl",
+        "//php/private:providers.bzl",
+        "//php/private/lock:BUILD.bazel",
+        "//php/private/lock:hub.bzl",
+        "//php/private/lock:repo.bzl",
+        "//php/private/toolchain:BUILD.bazel",
+        "//php/private/toolchain:cells.bzl",
+        "//php/private/toolchain:extensions.bzl",
+        "//php/private/toolchain:php.bzl",
+        "//php/private/toolchain:repos.bzl",
     ],
     tags = ["corpus"],
 )

php/private/toolchain/BUILD.bazel

@@ -1,10 +1,10 @@
 load("@rules_dx//php:defs.bzl", "php_library")
-load("//core/quality:fixtures.bzl", "real_source_target")
 load(":cells.bzl", "PHP_CELLS", "cell_settings", "unsupported_value")
 
 package(default_visibility = ["//visibility:public"])
 
 exports_files([
+    "BUILD.bazel",
     "cells.bzl",
     "php.bzl",
     "repos.bzl",
@@ -23,18 +23,6 @@ toolchain_type(name = "toolchain_type")
 
 toolchain_type(name = "exec_toolchain_type")
 
-real_source_target(
-    name = "corpus_starlark",
-    starlark_srcs = [
-        "BUILD.bazel",
-        "cells.bzl",
-        "php.bzl",
-        "repos.bzl",
-        "extensions.bzl",
-    ],
-    tags = ["corpus"],
-)
-
 php_library(
     name = "toolchain",
     srcs = ["version_check.php"],

tools/ci/BUILD.bazel

@@ -643,7 +643,6 @@ rust_test(
         "//perl/private:corpus_starlark",
         "//perl/private/quality:corpus_starlark",
         "//perl/tests:corpus_starlark",
-        "//php/private:corpus_starlark",
         "//php/private/quality:corpus_starlark",
         "//powershell/private:corpus_starlark",
         "//powershell/private/quality:corpus_starlark",
@@ -998,8 +997,6 @@ rust_test(
         "//ocaml/tests:corpus_starlark",
         "//perl/private/lock:corpus_starlark",
         "//perl/private/tools/lock:corpus_starlark",
-        "//php/private/lock:corpus_starlark",
-        "//php/private/toolchain:corpus_starlark",
         "//php/private/tools/lock:corpus_starlark",
         "//php/tests:corpus_starlark",
         "//powershell/private/lock:corpus_starlark",

tools/ci/rule_set_loads_allowlist.txt

@@ -7,12 +7,9 @@ lua/private/lua.bzl foreign-load 1
 lua/private/runtime/BUILD.bazel foreign-load 2
 lua/private/toolchain/BUILD.bazel foreign-load 2
 lua/private/toolchain/extensions.bzl foreign-load 1
-php/BUILD.bazel foreign-load 1
-php/private/BUILD.bazel foreign-load 4
+php/private/BUILD.bazel foreign-load 3
 php/private/defs.bzl foreign-load 5
-php/private/lock/BUILD.bazel foreign-load 1
 php/private/php.bzl foreign-load 1
-php/private/toolchain/BUILD.bazel foreign-load 1
 qt/BUILD.bazel foreign-load 1
 qt/private/BUILD.bazel foreign-load 5
 qt/private/archive.bzl foreign-load 1