Repository navigation
(3/8) fix(setup): gate DB port exposure, login lockout, forwarded headers, pair args - #146
Merged
Merged
Conversation
…pair args
- POST /ports/expose refuses looks-like-database ports without
{"confirmDatabase": true}
- key throttle locks an address out after 20 failures for a growing
window, rejecting at once without holding shared slots
- X-Forwarded-Proto/Host/Prefix only believed from loopback peers;
router warns loudly when T3_TRUST_PROXY_HEADERS is set
- /pair validates ttl against the CLI duration grammar and label
against printable text without a leading dash
Contributor
Author
This was referenced Nov 14, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen the Setup entry points while retaining existing deployment options:
confirmDatabase: truebefore starting a public tunnel for a database-like port.T3_TRUST_PROXY_HEADERS=1; scheme, host, prefix and visitor-address handling use the same trust decision.Document the proxy setting for both the single-port router and direct Setup deployments. The port-exposure regression fixture uses
/bin/falsefor cloudflared, so it cannot publish a real host port.Validation: all 64 focused front-door, throttle, request-auth, client-address, router and setup-key tests passed; all 9 front-door tests passed again after isolating the tunnel fixture. Current main, including #148's smoke correction, is merged for fresh native and image CI.
Original security work contributed by @0libote; maintainer review fixes retain explicit proxy support, international labels and isolated test behavior.