[johnnyhuy]

Adds WorkoutSwapSuggestion and EquipmentSwapManager.suggestEntrySwaps(for:from:) so catalogue suggestions carry the workout entry ID. Callers can select the second occurrence of a repeated exercise and apply its suggested alternative to that same entry, including after reordering; the existing tuple API shares the selection path and keeps its behaviour.

Completes the entry-aware catalogue suggestion slice. Part of #5. Closes #81.

Verified locally with the repository gates.

• mise run lint passed with 491 existing warnings and zero serious violations.
• mise run build passed.
• mise run test passed all 23 pipeline checks, 169 XCTest tests and 86 Swift Testing tests. The seven new tests are listed below.
• git diff --check passed.
• CI mise run build and mise run test passed on Linux in the SwiftPM job, including all 169 XCTest tests and 86 Swift Testing tests.
• CI mise run lint and mise run ios:build:ci passed in the iOS build job.
• All CodeQL and Socket checks passed.
• CI mise run ios:e2e passed with two flaky tests and two passed in the mobile e2e job. The first workout launch failed its foreground check, and skip rest lost its WebSocket connection. Both passed on internal retry Implement BetterFit iOS strength training coach core framework #1; the failures remain tracked in Stabilise first app launch in mobile e2e on CI #62.
• Initial CI mise run ios:coverage failed during ProfileJourneyUITests.testAchievementsSectionVisible setup because XCUITest could not terminate the previous app process. The other 26 tests passed. The initial job log and retained result bundle preserve this failure. The first isolated rerun passed that test but failed AdjustSetsUITests.testExerciseDetailShowsSetControls because the detail sheet did not open after tapping the focus exercise. It again passed 26 of 27 tests. The rerun result bundle preserves the Plan hierarchy at failure. Both UI reliability failures are tracked in Stabilise XCUITest app lifecycle and first exercise sheet readiness on CI #83. The final isolated UI coverage run passed all 27 tests on the unchanged commit. All PR checks are now green.

Proof

Unit test capture succeeded. This transcript from .tmp/proof/issue-81-test.log shows distinct suggestions for repeated entries, workout and catalogue ordering, omitted ineligible entries, empty inputs, availability changes, unchanged legacy suggestions, and applying a suggestion to the same entry after reordering. The second-entry application test checks full workout equality after changing only the selected exercise, including preserved sets, notes and metadata. Terminal glyphs were removed.

==> summary: 23 passed, 0 failed
Executed 169 tests, with 0 failures (0 unexpected) in 2.150 (2.167) seconds
Test suggestionStillTargetsSameEntryAfterReordering() passed after 0.010 seconds.
Test appliesSecondRepeatedEntrySuggestionAndPreservesWorkoutData() passed after 0.010 seconds.
Test identifiesRepeatedEntriesWithoutChangingWorkout() passed after 0.009 seconds.
Test tupleSuggestionsRemainCompatibleWithEntrySuggestions() passed after 0.009 seconds.
Test reflectsUpdatedEquipmentAvailability() passed after 0.008 seconds.
Test returnsNoEntrySuggestionsForEmptyInputs() passed after 0.009 seconds.
Test omitsIneligibleEntriesAndPreservesWorkoutAndCatalogueOrder() passed after 0.008 seconds.
Test run with 86 tests in 12 suites passed after 0.028 seconds.

The mobile e2e report retains the failed initial attempts and successful retries on the unchanged commit.

start workout, log a set, rest timer appears
Test timeout of 120000ms exceeded.
Error: app did not come to foreground
start workout, log a set, rest timer appears (retry #1) passed
skip rest dismisses the timer
Error: WebSocket connection closed (code=1006, reason=no reason)
skip rest dismisses the timer (retry #1) passed
2 flaky
2 passed (12.3m)

Both failed UI attempts are retained above. The initial failure was in app launch setup; the first rerun remained on Plan after a tap instead of opening the exercise sheet. Each failed test passed in the other attempt.

Initial attempt
ProfileJourneyUITests.testAchievementsSectionVisible
Failed to terminate dev.echohello.BetterFit
Executed 27 tests, with 1 failure

First isolated rerun
AdjustSetsUITests.testExerciseDetailShowsSetControls
XCTAssertTrue failed - Detail sheet should list the sets section
Executed 27 tests, with 1 failure

The final UI result bundle shows the full existing app suite passing on the same commit after those two failed attempts.

Executed 27 tests, with 0 failures (0 unexpected) in 388.662 (388.681) seconds
** TEST SUCCEEDED **

No app UI or user-facing app behaviour changed. Simulator screenshots and local UI tests were not required, and no capture method was blocked. Scratch captures are not committed.

Suggestions are snapshots. Callers should regenerate them after editing a workout or changing available equipment. Swap application still accepts the caller's selected exercise without revalidating equipment or muscle matching. App wiring, movement equivalence and load adjustment remain follow-up slices. Parent #5 remains open. CI UI reliability remains a follow-up in #83, separate from the mobilewright failures in #62.