Repository navigation
Fail on open if tcsetattr doesn't set bits/parity - #232
Merged
Merged
Conversation
This fixes a confusing situation where opening a pseudo-terminal would "work" the first time and then fail afterwards if requesting 7 data bits and parity. Pseudo-terminals only support 8n1, so the subsequent failures were correct but unexpected. This could catch other silent failures that appeared to work in the past.
This verifies the previous commit that detects tcsetattr failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a confusing situation where opening a pseudo-terminal would
"work" the first time and then fail afterwards if requesting 7 data bits
and parity. Pseudo-terminals only support 8n1, so the subsequent
failures were correct but unexpected.
This could catch other silent failures that appeared to work in the
past.
Fixes #226