Repository navigation
Conversation
The invite was only written to the activity log after the invitation email had been sent, inside after(). A slow email send (up to 9s) kept the invite out of the activity log well after the form said it was sent, which made team-invite-activity.spec.ts fail about a third of the time. Log the invite before responding, as every other action does, and keep only the email in after(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
team-invite-activity.spec.tshas failed on about a third of runs since 1a95e67. That commit moved the activity log write intoafter(), behindsendInvitationEmail. A quarter of email sends take 6–9 s, so the invite didn't appear in the activity log until long after the form showed "Invitation sent successfully". The test's 5 s expect ran out first. This also affected PR #3, which doesn't touch this code.What
await logActivity(...)before the action responds, like every other action inactions.tsdoes.after(), so a slow email provider still doesn't slow down inviting.The test stays as it is: the activity log should show the invite as soon as the app says it was sent.
🤖 Generated with Claude Code