Skip to content

Log team invites before responding, not after the email #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ostenbom wants to merge 1 commit into from
Closed

Log team invites before responding, not after the email #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions app/(login)/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,17 @@ export const inviteTeamMember = validatedActionWithUser(
})
.returning();

// Email the invitee and log the invite once the response has been sent,
// so inviting feels instant.
const teamId = userWithTeam.teamId;
after(async () => {
await sendInvitationEmail(email, role);
await logActivity(teamId, user.id, ActivityType.INVITE_TEAM_MEMBER);
});
// Log the invite before responding, so the activity log is up to date as
// soon as the invite form says it was sent.
await logActivity(
userWithTeam.teamId,
user.id,
ActivityType.INVITE_TEAM_MEMBER,
);

// Email the invitee once the response has been sent, so a slow email
// provider doesn't slow down inviting.
after(() => sendInvitationEmail(email, role));

return { success: "Invitation sent successfully", id: invitation[0].id };
},
Expand Down
Loading