chore: Replace devtools build_and_copy with a script that avoids the deprecated pwa-strategy flag - #4078
Closed
spydon wants to merge 1 commit into
Closed
chore: Replace devtools build_and_copy with a script that avoids the deprecated pwa-strategy flag#4078spydon wants to merge 1 commit into
spydon wants to merge 1 commit into
Conversation
…deprecated pwa-strategy flag
Member
Author
|
Wait for the fix upstream to land instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
melos devtools-buildfails with:The flag is not used anywhere in this repository. It is hardcoded inside the
build_and_copycommand of thedevtools_extensionspackage, and every published version of that package still passes it, including the latest 0.5.1, so upgrading the dependency does not help.This PR replaces the upstream command with
scripts/devtools-build.sh, which mirrors it step by step without the deprecated flag: it runs the release web build offlame_devtools, fixes the canvaskit file permissions, and replaces the build folder underpackages/flame/extension/devtools. Themelos devtools-buildcommand keeps its name, so the existing references in the READMEs remain valid.Verified locally by running
melos devtools-build, which now builds and copies the extension without the error.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues