Skip to content

chore: Replace devtools build_and_copy with a script that avoids the deprecated pwa-strategy flag #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spydon wants to merge 1 commit into from
Closed

chore: Replace devtools build_and_copy with a script that avoids the deprecated pwa-strategy flag #4078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ melos:
description: Re-generate all golden test files

devtools-build:
run: melos exec -- dart run devtools_extensions build_and_copy --source=. --dest=../flame/extension/devtools
packageFilters:
scope: flame_devtools
run: ./scripts/devtools-build.sh
description: Builds the devtools and copies the build directory to the Flame package.

devtools-simulator:
Expand Down
29 changes: 29 additions & 0 deletions scripts/devtools-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#!/usr/bin/env bash
set -e

# Builds the Flame DevTools extension and copies the output into the flame
# package, mirroring `dart run devtools_extensions build_and_copy` but without
# the deprecated `--pwa-strategy` flag that the upstream command still passes.

root_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
source_dir="$root_dir/packages/flame_devtools"
destination_dir="$root_dir/packages/flame/extension/devtools/build"

echo "[devtools-build] Building the extension Flutter web app..."
(
cd "$source_dir"
flutter build web --release --no-tree-shake-icons
)

if [[ -d "$source_dir/build/web/canvaskit" ]]; then
echo "[devtools-build] Setting canvaskit permissions..."
chmod 0755 "$source_dir/build/web/canvaskit/canvaskit.js" \
"$source_dir/build/web/canvaskit/canvaskit.wasm"
fi

echo "[devtools-build] Replacing the existing extension build with the new one..."
rm -rf "$destination_dir"
mkdir -p "$destination_dir"
cp -R "$source_dir/build/web/." "$destination_dir"

echo "[devtools-build] Successfully copied extension assets to \"$destination_dir\""
Loading