Repository navigation
build(deps): Upgrade Rust and Python dependencies - #744
Merged
Merged
Conversation
Semver Impact of This PR⚪ None (no workspace changed) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR does not change any workspace, so it will not appear in any changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 91.56% 91.55% -0.02%
==========================================
Files 116 116
Lines 22084 22088 +4
==========================================
Hits 20222 20222
- Misses 1862 1866 +4
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
approved these changes
Oct 30, 2026
jan-auer
added a commit
that referenced
this pull request
Oct 30, 2026
The published crates expose error types from two dependencies. Because of this, a major upgrade of these dependencies is a breaking change for our users. #744 keeps them on their current versions for this reason. This PR makes the breaking change once, so that later upgrades are not breaking: - `objectstore_client::Error::TokenError` now contains `objectstore_client::TokenError` instead of `jsonwebtoken::errors::Error`. - `objectstore_types::metadata::Error::ContentType` now contains `objectstore_types::metadata::InvalidContentType` instead of `mediatype::MediaTypeError`. The new types are opaque. They show the message of the underlying error, so errors are as descriptive as before. The public API no longer has `From` conversions from the dependency error types. The token error message now also gives context, for example `failed to create auth token: InvalidKeyFormat` instead of only `InvalidKeyFormat`.
jan-auer
added a commit
that referenced
this pull request
Nov 4, 2026
This is a leftover from #744. `PrefetchingTokenProvider` now holds its refresh task in an `AbortOnDropHandle`, which replaces the custom `Drop` impl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dependencies. The public API of the published crates,
objectstore-clientandobjectstore-types, stays the same.Compatible Rust updates change only
Cargo.lock. The minimum versions inCargo.tomlstay the same. Users of the published crates do not have to upgrade their own dependencies.These Rust crates move to a new major version. They need no code changes, and none of their types are part of a public API:
All Python dependencies are at their latest versions, including mypy 2.
Three crates stay on their current major version because the published crates expose their types. A separate PR will update them as a breaking change:
objectstore_client::Error::TokenErrorwraps its error type.objectstore_types::metadata::Error::ContentTypewraps its error type.objectstore_types::presignre-exports its key types. Also, jsonwebtoken 11 still depends on ed25519-dalek 2.The minimum supported Rust version of the client (1.89) does not change.
Changelog Entry
Upgrade dependencies.
utils::guess_mime_typenow detects a PDF when%PDFoccurs anywhere in the first 1024 bytes, not only at the start. Text content that contains%PDFnear the start can now returnapplication/pdf.