Skip to content

ref(service): Use AbortOnDropHandle for the token refresh task - #762

Merged
jan-auer merged 1 commit into
mainfrom
ref/abort-on-drop-handle
Nov 4, 2026
Merged

jan-auer merged 1 commit into
mainfrom
ref/abort-on-drop-handle

Conversation

@jan-auer

@jan-auer jan-auer commented Nov 4, 2026

Copy link
Copy Markdown
Member

This is a leftover from #744. PrefetchingTokenProvider now holds its refresh task in an AbortOnDropHandle, which replaces the custom Drop impl.

#skip-changelog

@jan-auer
jan-auer requested a review from a team as a code owner November 4, 2026 14:23
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Changelog Preview

This PR lands in these workspaces:

  • objectstore-server: CalVer
📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@sentry-junior sentry-junior Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. AbortOnDropHandle gives the same abort-on-drop behavior the manual Drop impl did. tokio-util already has the rt feature enabled in objectstore-service, so nothing new gets pulled in. The existing drop_cancels_task test still covers the drop path. task had no other readers, so renaming it to _task is fine.

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.81%. Comparing base (5bb5372) to head (35fd34e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         119      119           
  Lines       22837    22834    -3     
=======================================
- Hits        20968    20966    -2     
+ Misses       1869     1868    -1     
Components Coverage Δ
Rust Backend 94.80% <100.00%> (-0.01%) ⬇️
Rust Client 89.13% <ø> (ø)
Python Client 91.64% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-auer
jan-auer merged commit c9ad3fe into main Nov 4, 2026
26 checks passed
@jan-auer
jan-auer deleted the ref/abort-on-drop-handle branch November 4, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants