Repository navigation
ref(service): Use AbortOnDropHandle for the token refresh task - #762
Conversation
Changelog PreviewThis PR lands in these workspaces:
📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Looks good to me. AbortOnDropHandle gives the same abort-on-drop behavior the manual Drop impl did. tokio-util already has the rt feature enabled in objectstore-service, so nothing new gets pulled in. The existing drop_cancels_task test still covers the drop path. task had no other readers, so renaming it to _task is fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 119 119
Lines 22837 22834 -3
=======================================
- Hits 20968 20966 -2
+ Misses 1869 1868 -1
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This is a leftover from #744.
PrefetchingTokenProvidernow holds its refresh task in anAbortOnDropHandle, which replaces the customDropimpl.#skip-changelog