Skip to content

ref(service): Use AbortOnDropHandle for the token refresh task #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-auer merged 1 commit into from
Nov 4, 2026
Merged

ref(service): Use AbortOnDropHandle for the token refresh task #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions objectstore-service/src/gcp_auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ use std::time::Duration;
use async_trait::async_trait;
use chrono::Utc;
use tokio::sync::watch;
use tokio::task::JoinHandle;
use tokio::time::Instant;
use tokio_util::task::AbortOnDropHandle;

/// How far ahead of expiry to start refreshing.
///
Expand Down Expand Up @@ -82,13 +82,8 @@ pub struct PrefetchingTokenProvider {
scopes: Vec<&'static str>,
rx: watch::Receiver<TokenResult>,
provider: Arc<dyn gcp_auth::TokenProvider>,
task: JoinHandle<()>,
}

impl Drop for PrefetchingTokenProvider {
fn drop(&mut self) {
self.task.abort();
}
/// Aborts the background refresh task when the provider is dropped.
_task: AbortOnDropHandle<()>,
}

impl std::fmt::Debug for PrefetchingTokenProvider {
Expand Down Expand Up @@ -128,7 +123,7 @@ impl PrefetchingTokenProvider {
scopes: scopes.to_vec(),
rx,
provider,
task,
_task: AbortOnDropHandle::new(task),
})
}
}
Expand Down
Loading