Repository navigation
fix(scanner): trust non production GoDaddy domains in SEC112 - #373
Merged
Merged
Conversation
mguerrero3-godaddy
requested review from
axburgess-godaddy,
jpage-godaddy,
jpearlman-godaddy,
qcai-godaddy,
rts1-godaddy,
sgopalan-godaddy,
smukherjee-godaddy and
wcole1-godaddy
as code owners
November 16, 2026 16:05
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
SEC112 still blocks newly trusted bare-host URLs because closing quotes are not accepted as URL boundaries; string and template-literal terminators need support and regression coverage.
1 open issue
What changed in this PR
This PR extends the extension security scanner’s trusted domains to GoDaddy’s development, test, and OTE hosts, aligning pre-bundle warnings with post-bundle blocking rules.
Changes:
- Add the three non-production domains and their subdomains to both allowlists.
- Add SEC112 tests for trusted URLs and lookalike domains that must remain blocked.
| File | Description |
|---|---|
rust/src/platform/app/extension/security/tests_sec109_115.rs |
Adds trusted-host and lookalike regression tests. |
rust/src/platform/app/extension/security/rules.rs |
Extends SEC112’s trusted-domain pattern. |
rust/src/platform/app/extension/security/config.rs |
Adds matching domains to the SEC008 allowlist. |
Review effort: Balanced
jpage-godaddy
approved these changes
Nov 16, 2026
jpage-godaddy
force-pushed
the
fix/sec112-trust-nonprod-godaddy-domains
branch
from
November 16, 2026 17:53
f201371 to
00ea107
Compare
jpage-godaddy
self-requested a review
November 16, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Extension deploys were blocked by SEC112 when the bundle called GoDaddy's non-production service URLs (
dev-godaddy.com,test-godaddy.com,ote-godaddy.com). Onlygodaddy.comand its subdomains were trusted, so those hosts were reported as outside the GoDaddy allowlist, while the prod URL passed.This adds those three hosts, and their subdomains, to the trusted list.
Changes
rules.rs: the SEC112 pattern accepts an optionaldev-,test-orote-prefix directly beforegodaddy.com.config.rs:trusted_domainslists the same three hosts and their subdomains, so the external-URL warning (SEC008) agrees with SEC112.tests_sec109_115.rs: new tests for the allowed hosts (including subdomains, a port and a query string) and for lookalikes that must still block:evil-dev-godaddy.com,dev-godaddy.com.evil.net,stage-godaddy.com,devgodaddy.com,dev-godaddy.co, and a URL withdev-godaddy.comonly in its path.Behavior notes
*-godaddy.compattern, so a registrable lookalike such asevil-godaddy.comis still blocked.Verification
cargo check --workspace,cargo clippy --workspace -- -D warnings,cargo test --workspace,cargo fmt --checkand./rust/scripts/check-module-size.shall pass.