Skip to content

fix(scanner): trust non production GoDaddy domains in SEC112 - #373

Merged
jpage-godaddy merged 3 commits into
mainfrom
fix/sec112-trust-nonprod-godaddy-domains
Nov 16, 2026
Merged

jpage-godaddy merged 3 commits into
mainfrom
fix/sec112-trust-nonprod-godaddy-domains

Conversation

@mguerrero3-godaddy

Copy link
Copy Markdown
Collaborator

Summary

Extension deploys were blocked by SEC112 when the bundle called GoDaddy's non-production service URLs (dev-godaddy.com, test-godaddy.com, ote-godaddy.com). Only godaddy.com and its subdomains were trusted, so those hosts were reported as outside the GoDaddy allowlist, while the prod URL passed.

This adds those three hosts, and their subdomains, to the trusted list.

Changes

  • rules.rs: the SEC112 pattern accepts an optional dev-, test- or ote- prefix directly before godaddy.com.
  • config.rs: trusted_domains lists the same three hosts and their subdomains, so the external-URL warning (SEC008) agrees with SEC112.
  • tests_sec109_115.rs: new tests for the allowed hosts (including subdomains, a port and a query string) and for lookalikes that must still block: evil-dev-godaddy.com, dev-godaddy.com.evil.net, stage-godaddy.com, devgodaddy.com, dev-godaddy.co, and a URL with dev-godaddy.com only in its path.

Behavior notes

  • The hosts are matched exactly, not by a *-godaddy.com pattern, so a registrable lookalike such as evil-godaddy.com is still blocked.
  • The allowance applies to every extension deploy, not only to dev deploys. The scanner doesn't know the target environment, and these are GoDaddy's own hosts.

Verification

cargo check --workspace, cargo clippy --workspace -- -D warnings, cargo test --workspace, cargo fmt --check and ./rust/scripts/check-module-size.sh all pass.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

SEC112 still blocks newly trusted bare-host URLs because closing quotes are not accepted as URL boundaries; string and template-literal terminators need support and regression coverage.

1 open issue
What changed in this PR

This PR extends the extension security scanner’s trusted domains to GoDaddy’s development, test, and OTE hosts, aligning pre-bundle warnings with post-bundle blocking rules.

Changes:

  • Add the three non-production domains and their subdomains to both allowlists.
  • Add SEC112 tests for trusted URLs and lookalike domains that must remain blocked.
File Description
rust/​src/​platform/​app/​extension/​security/​tests_sec109_115.rs Adds trusted-host and lookalike regression tests.
rust/​src/​platform/​app/​extension/​security/​rules.rs Extends SEC112’s trusted-domain pattern.
rust/​src/​platform/​app/​extension/​security/​config.rs Adds matching domains to the SEC008 allowlist.

Review effort: Balanced

@jpage-godaddy
jpage-godaddy force-pushed the fix/sec112-trust-nonprod-godaddy-domains branch from f201371 to 00ea107 Compare November 16, 2026 17:53
@jpage-godaddy
jpage-godaddy requested a balanced review from Copilot November 16, 2026 17:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated URL pattern introduces a critical allowlist bypass: an embedded apostrophe lets a request targeting evil.net evade SEC112 detection.

1 open issue
1 resolved since last review

Review effort: Balanced

@jpage-godaddy
jpage-godaddy self-requested a review November 16, 2026 18:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scanner’s trusted-domain update has no active review issues.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jpage-godaddy
jpage-godaddy merged commit 4e46dca into main Nov 16, 2026
6 checks passed
@jpage-godaddy
jpage-godaddy deleted the fix/sec112-trust-nonprod-godaddy-domains branch November 16, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants