Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion rust/src/platform/app/extension/security/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,18 @@ use super::types::SecurityConfig;

pub fn security_config() -> SecurityConfig {
SecurityConfig {
trusted_domains: vec!["*.godaddy.com", "godaddy.com", "localhost", "127.0.0.1"],
trusted_domains: vec![
"*.godaddy.com",
"godaddy.com",
"*.dev-godaddy.com",
"dev-godaddy.com",
"*.test-godaddy.com",
"test-godaddy.com",
"*.ote-godaddy.com",
"ote-godaddy.com",
"localhost",
"127.0.0.1",
],
exclude: vec![
"**/node_modules/**",
"**/dist/**",
Expand Down
11 changes: 9 additions & 2 deletions rust/src/platform/app/extension/security/rules.rs
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,21 @@ pub(super) static RULE_DEFS: &[RuleDef] = &[
r#"\brmSync\s*\("#,
],
},
// SEC112 — requests to untrusted domains (no signal, block)
// SEC112 — requests to untrusted domains (no signal, block). Trusts godaddy.com plus
// the exact non-production hosts dev-/test-/ote-godaddy.com (and their subdomains).
// A closing quote ends the host only when it matches the quote that opened the URL
// string, so `"https://godaddy.com'@evil.net"` (userinfo) is still blocked.
// Keep in sync with `trusted_domains` in config.rs.
RuleDef {
id: "SEC112",
severity: Severity::Block,
description: "Bundled code makes requests to domains outside the GoDaddy trusted allowlist",
signal_patterns: &[],
patterns: &[
r#"https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s]|$))[^\s"'\x60<>]+"#,
r#"(?<=")https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s"]|$))[^\s"'\x60<>]+"#,
r#"(?<=')https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s']|$))[^\s"'\x60<>]+"#,
r#"(?<=\x60)https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s\x60]|$))[^\s"'\x60<>]+"#,
r#"(?<!["'\x60])https?://(?!(?:(?:[a-zA-Z0-9-]+\.)*(?:dev-|test-|ote-)?godaddy\.com|localhost|127\.0\.0\.1)(?:[:/?#\s]|$))[^\s"'\x60<>]+"#,
],
},
// SEC113 — any encoded payload (no signal, warn)
Expand Down
87 changes: 87 additions & 0 deletions rust/src/platform/app/extension/security/tests_sec109_115.rs
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,93 @@ fn sec112_godaddy_lookalike_blocked() {
);
}

#[test]
fn sec112_nonprod_godaddy_domains_allowed() {
for url in [
"https://dev-godaddy.com/v1",
"https://api.dev-godaddy.com/v1",
"https://test-godaddy.com/v1",
"https://api.test-godaddy.com:8443/v1",
"https://ote-godaddy.com/v1",
"https://api.ote-godaddy.com/v1?x=1",
] {
let findings = scan_bundle(&format!(r#"fetch("{url}");"#), "test.mjs");
assert!(
findings.iter().all(|f| f.rule_id != "SEC112"),
"{url} should be trusted: {findings:?}"
);
}
}

#[test]
fn sec112_bare_host_urls_allowed() {
for code in [
r#"fetch("https://dev-godaddy.com");"#,
r#"fetch('https://test-godaddy.com');"#,
"fetch(`https://ote-godaddy.com`);",
r#"fetch("https://godaddy.com");"#,
r#"fetch("https://api.godaddy.com");"#,
r#"fetch("http://localhost");"#,
r#"fetch("http://127.0.0.1");"#,
] {
let findings = scan_bundle(code, "test.mjs");
assert!(
findings.iter().all(|f| f.rule_id != "SEC112"),
"{code} should be trusted: {findings:?}"
);
}
}

#[test]
fn sec112_bare_host_lookalikes_blocked() {
for code in [
r#"fetch("https://evil.net");"#,
r#"fetch("https://evil-dev-godaddy.com");"#,
r#"fetch('https://dev-godaddy.com.evil.net');"#,
"fetch(`https://stage-godaddy.com`);",
] {
let findings = scan_bundle(code, "test.mjs");
assert!(
findings.iter().any(|f| f.rule_id == "SEC112"),
"{code} should not be trusted: {findings:?}"
);
}
}

#[test]
fn sec112_nonprod_godaddy_lookalikes_blocked() {
for url in [
"https://evil-dev-godaddy.com/",
"https://dev-godaddy.com.evil.net/",
"https://stage-godaddy.com/",
"https://devgodaddy.com/",
"https://dev-godaddy.co/",
"https://evil.net/dev-godaddy.com",
] {
let findings = scan_bundle(&format!(r#"fetch("{url}");"#), "test.mjs");
assert!(
findings.iter().any(|f| f.rule_id == "SEC112"),
"{url} should not be trusted: {findings:?}"
);
}
}

#[test]
fn sec112_mixed_quote_userinfo_blocked() {
for code in [
r#"https.get("https://godaddy.com'@evil.net/steal");"#,
r#"https.get('https://godaddy.com"@evil.net/steal');"#,
"https.get(`https://godaddy.com'@evil.net/steal`);",
r#"https.get("https://dev-godaddy.com`@evil.net/steal");"#,
] {
let findings = scan_bundle(code, "test.mjs");
assert!(
findings.iter().any(|f| f.rule_id == "SEC112"),
"{code} should not be trusted: {findings:?}"
);
}
}

// -----------------------------------------------------------------------
// SEC113 — any encoded payload (no signal, warn)
// -----------------------------------------------------------------------
Expand Down
Loading