Repository navigation
Conversation
Represent slice-DST sizes as C + round_up(r + nE, A), encoding A and r in one nonzero word. Carry that four-word layout formula through composition, padding, metadata inference, casts, projections, allocation, and split overlap checks. This is a smaller state-model alternative to #3630. Exhaustive reduced-width model checking matches #3630's core formula transforms and representability behavior, and the checked benchmark snapshots are byte-for-byte identical. Add regression coverage for compiler-accepted generic packed/aligned nesting, parsing, allocation, zeroing, projection, metadata plateaus, and dynamic padding. Add modular Kani proofs for the normal form, transforms, inverse validator, affine cast arithmetic, alignment, containment, the conservative dynamic-padding predicate, and both modern and MSRV unchecked-arithmetic implementations. The arithmetic proofs are conditional on the documented compiler-layout premise; regression and Miri coverage exercise the actual compiler layout and pointer paths. Closes #3617 *Authored by an AI agent acting on Josh Liebow-Feeser's and Jack Wrenn's behalf.* gherrit-pr-id: Ge2cllcsxpw6mt6keaxk2hu3vg67rdk6i Agent-authored-by: AI agent acting on joshlf's behalf (content only)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86b2094a28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,22 @@ | |||
| #[allow( | |||
There was a problem hiding this comment.
Add the required copyright header to the new snapshot
This newly added .expected.rs file starts directly with generated tokens and therefore omits the required repository copyright header and creation year. Add the 2026 header and ensure the ZEROCOPY_BLESS path preserves it when regenerating snapshots.
AGENTS.md reference: zerocopy/AGENTS.md:L35-L36
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3778 +/- ##
==========================================
- Coverage 93.16% 92.94% -0.22%
==========================================
Files 16 16
Lines 2413 2466 +53
==========================================
+ Hits 2248 2292 +44
- Misses 165 174 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
86b2094 to
7c8ecd9
Compare
Pull request was closed
Represent slice-DST sizes as C + round_up(r + nE, A), encoding A and r in one nonzero word. Carry that four-word layout formula through composition, padding, metadata inference, casts, projections, allocation, and split overlap checks.
This is a smaller state-model alternative to #3630. Exhaustive reduced-width model checking matches #3630's core formula transforms and representability behavior, and the checked benchmark snapshots are byte-for-byte identical.
Add regression coverage for compiler-accepted generic packed/aligned nesting, parsing, allocation, zeroing, projection, metadata plateaus, and dynamic padding. Add modular Kani proofs for the normal form, transforms, inverse validator, affine cast arithmetic, alignment, containment, the conservative dynamic-padding predicate, and both modern and MSRV unchecked-arithmetic implementations. The arithmetic proofs are conditional on the documented compiler-layout premise; regression and Miri coverage exercise the actual compiler layout and pointer paths.
Closes #3617
Authored by an AI agent acting on Josh Liebow-Feeser's and Jack Wrenn's behalf.
Agent-authored-by: AI agent acting on joshlf's behalf (content only)
TrailingSliceLayoutand removeSplit::via_unaligned#3778Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Ge2cllcsxpw6mt6keaxk2hu3vg67rdk6i && git checkout -b pr-Ge2cllcsxpw6mt6keaxk2hu3vg67rdk6i FETCH_HEADCheckout
git fetch origin refs/heads/Ge2cllcsxpw6mt6keaxk2hu3vg67rdk6i && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Ge2cllcsxpw6mt6keaxk2hu3vg67rdk6i && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.