Skip to content

Separate numerical cast planning from typed pointer projection - #3774

Open
joshlf wants to merge 1 commit into
Gvvdmej5q7tk5o76yu4c26esuzqpvpdcafrom
Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx
Open

joshlf wants to merge 1 commit into
Gvvdmej5q7tk5o76yu4c26esuzqpvpdcafrom
Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx

Conversation

@joshlf

@joshlf joshlf commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Hoist the numerical CastPlan out of the generic pointer method. Keep
CastParams<Src, Dst> as the private connection to the selected KnownLayout
pair, and select its plan through an associated constant instead of the
local Params trait. Project then reads metadata, applies the selected plan,
and reconstructs the destination pointer.

Preserve the complete-size plan selection and unchecked arithmetic from
the base fix. Add Aeneas proofs in the following commits.

Agent-authored-by: AI agent acting on joshlf's behalf


Latest Update: v9 — Compare vs v8

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx && git checkout -b pr-Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx FETCH_HEAD

Checkout

git fetch origin refs/heads/Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T15:32:15.787649Z 44c82ce PR opened
🔒 Security Review ✅ Completed 2026-10-05T15:34:40.436000Z 44c82ce PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

codecov-commenter commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.75610% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.43%. Comparing base (0c56a2e) to head (d612884).

Files with missing lines Patch % Lines
zerocopy/src/layout/cast_from.rs 9.75% 74 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           Gvvdmej5q7tk5o76yu4c26esuzqpvpdca    #3774       +/-   ##
======================================================================
- Coverage                              92.94%   61.43%   -31.52%     
======================================================================
  Files                                     17       20        +3     
  Lines                                   2466     3713     +1247     
======================================================================
- Hits                                    2292     2281       -11     
- Misses                                   174     1432     +1258     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Hoist the numerical CastPlan out of the generic pointer method. Keep
CastParams<Src, Dst> as the private connection to the selected KnownLayout
pair, and select its plan through an associated constant instead of the
local Params trait. Project then reads metadata, applies the selected plan,
and reconstructs the destination pointer.

Preserve the complete-size plan selection and unchecked arithmetic from
the base fix. Add Aeneas proofs in the following commits.

Agent-authored-by: AI agent acting on joshlf's behalf
gherrit-pr-id: Gysrrwrr4oyfrqso6dw7gdmpjocmskwtx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants