Repository navigation
Deliver Codex tasks safely and keep orchestration MCP connected - #152
pepechka-kun wants to merge 1 commit into
Conversation
…ation MCP reliably Queued tasks could stay in the composer, overwrite drafts or lose MCP access after a new thread. Wait for the current launch, paste explicitly, and bind helper reconnects to the same live session.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d29c9bde1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| input(id: string, data: string): void { | ||
| const session = this.sessions.get(id); | ||
| if (session) delete session.codexDraftEpoch; |
There was a problem hiding this comment.
When an orchestrator or plugin first creates a paste-only Codex draft and the user then edits or submits it through the mobile/Even G2 companion, this ownership marker is not cleared: the companion host routes session input, keys, and voice sends through inputChecked rather than this input method (src/main/services/companion/EvenG2Controller.ts:220-223 and 1194-1197). A later automated send therefore sees codexDraftEpoch === epoch, skips composer inspection, and can append to the user's draft or write while their submitted turn is active. Clear the marker in the common checked-write path (with deliverInput re-establishing it for paste-only automation) or explicitly clear it from every human-input route.
Useful? React with 👍 / 👎.
|
Superseded by #155. The replacement contains all local follow-up fixes in a single topic commit on current main, with fresh local validation. Closing this older history in favor of that PR. |
1 participant
Automated Codex tasks could remain unsent, overwrite a typed draft, or lose orchestration tools when a new CLI thread started inside the same terminal.
Wait for the current launch's empty composer, submit with bracketed paste, expose only the allowed coordination tools directly, and let additional helpers authenticate to that same live launch. Startup menus, cancellation and stale/restarted sessions remain guarded.
Validation: typecheck; full local suite (2,212 tests: 2,186 passed, 26 platform skips); real Codex 0.163.0 with temporary profiles and loopback MCP/Responses fixtures (four exposure/allowlist cases). The synthetic catalog includes the parallel-tool capability required by the installed CLI.
Extracted from #151 into one topical commit directly on the current upstream main. Working installations and services are unchanged.
Companion PRs: #154, #153. All target main and have been tested independently. Their combined merge was also checked locally without conflicts.
Combined validation: typecheck and 153 focused contract checks (151 passed, 2 platform skips).