Repository navigation
Deliver Codex tasks safely and preserve MCP access - #155
pepechka-kun wants to merge 11 commits into
Conversation
Codex tasks could remain unsent, overwrite drafts or lose coordination tools after thread changes. Wait for an owned empty composer, use bracketed paste, expose the allowed MCP tools directly and keep launch-scoped authentication and starting status accurate.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad1d911efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ad1d911 to
f41b036
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f41b03610d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Startup rows above Codex input were skipped, while the live smoke lost placeholder styling. Check current startup rows and return terminal-derived composer readiness to control clients.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 510d947b8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Styled empty composers could hide a live confirmation above them, while animation cells prevented native control from recognizing readiness. Gate standalone confirmations and reuse the existing screen normalization.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd17dcdcbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…p gates Readiness erased unstyled Braille and treated answer-prefixed confirmation text as an active gate. Normalize only fully dim placeholder input and keep submitted-answer rows separate from initial startup status in every delivery path.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bfe3c1af7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A blanket bullet exemption admitted post-turn MCP startup and missed indented answer continuations. Parse progress counters independently and track the indentation of completed assistant blocks.
Recognize a complete live progress row separately from indented transcript text, including counter examples and prose following a counter.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d3a8e453e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Tall replies can scroll the submitted question out of xterm. Classify answer bullets and their continuations independently of that question while preserving structured live MCP status gates.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 169438257f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The native UI also uses a black-circle marker already supported by presentation parsing. Include it consistently in startup and answer recognition, with coverage across all supported markers.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2a2b4328a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The first prompt row alone could appear empty while later input rows held a human draft. Check continuation rows through native terminal styling; do not accept footer-shaped typed text as UI metadata.
A continuation containing the prompt glyph could masquerade as an empty composer. Keep native marker indentation and soft-wrap boundaries consistent across text and styled checks, including wrapped footer metadata.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c7c8373e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A historical paragraph could block delivery after its prompt and bullet scrolled out. Use transcript indentation while retaining structured startup and framed confirmation guards; cover clipped viewport delivery and real blockers.
1 participant
Superseded by #158, a smaller bugfix-only PR from current main. Optional features and workflow/security-policy changes from this proposal are not included in the replacement. This branch and discussion remain available for reference.
Codex tasks could stay in the composer, overwrite a draft, or lose coordination tools after a thread change. Use bracketed paste only when the current launch owns an empty composer, preserve MCP access across thread changes, and report starting sessions accurately.
Readiness distinguishes styled native placeholders, multiline drafts, wrapped footer rows, historical transcript continuations and live startup/confirmation screens. Delivery, native control and material handoffs share the same checks; the live smoke uses terminal-derived
screen.composerReady.Validation: 164 delivery/control/handoff tests passed. Latest full combined local check with #156 and #157: 2,355 passed, 27 skipped, no failures; typecheck and source secret audit passed. No installed application, services, profiles or accounts changed.
Companion topics: #156 and #157; each is based independently on main.