Repository navigation
Let the user set maxFeePerGas - #10
Open
techdigger wants to merge 1 commit into
Open
techdigger wants to merge 1 commit into
techdigger wants to merge 1 commit into
Conversation
safe-cli takes maxFeePerGas from eth_feeHistory and gives the user no way to change it. A network that charges more than its fee history forecasts refuses each transaction safe-cli sends, and on a busy network the user may want a higher cap. The environment variable SAFE_CLI_MAX_FEE_PER_GAS, in gwei, sets maxFeePerGas for the EIP-1559 transactions safe-cli sends: execution with a local key, approve_hash and execution with a hardware wallet. The tip stays the estimate, lowered to the cap if needed. Without the variable safe-cli behaves as before and makes no extra request. safe-cli refuses a value that is not a positive decimal number when it starts. When it sends, it refuses a cap of 9.9 times the node's gas price or more, which catches one zero too many.
Closed
techdigger
changed the title
techdigger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commiton the changed filesWhat was wrong?
safe-cli picks
maxFeePerGasitself and gives no way to set it. Other tools let you:cast sendhas--gas-price.How was it fixed?
SAFE_CLI_MAX_FEE_PER_GAS=<gwei>setsmaxFeePerGasfor the transactions safe-cli sends. When unset, nothing changes.safe-creatordoes not read it.