Repository navigation
Ledger: pass gasPrice when signing a legacy transaction - #5
Closed
techdigger wants to merge 1 commit into
Closed
techdigger wants to merge 1 commit into
techdigger wants to merge 1 commit into
Conversation
LedgerWallet.get_signed_raw_transaction passes only maxFeePerGas and maxPriorityFeePerGas to ledgereth. For a legacy transaction, which execute_safe_tx builds on networks without EIP-1559, ledgereth then assumes a gas price of 0, so the Ledger signs a transaction the network refuses. Pass gasPrice too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LedgerWallet.get_signed_raw_transactionnow passesgasPriceto ledgereth'screate_transaction, alongsidemaxFeePerGasandmaxPriorityFeePerGas.Why
It passed only the EIP-1559 fields. On networks without EIP-1559,
execute_safe_txbuilds a legacy transaction withgasPrice. ledgereth then finds no price and assumes 0, so the Ledger signs a transaction the network refuses. Trezor already handles both types.Tested
A new test in
tests/test_hw_wallet_manager.pychecks the call tocreate_transaction: a legacy transaction passesgas_price, and an EIP-1559 one passes the max fees and nogas_price. I did not test with a physical Ledger.Generated by Claude Code