Skip to content

Ledger: pass gasPrice when signing a legacy transaction #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
techdigger wants to merge 1 commit into from
Closed

Ledger: pass gasPrice when signing a legacy transaction #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/safe_cli/operators/hw_wallets/ledger_wallet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def get_signed_raw_transaction(
gas=tx_parameters["gas"],
nonce=tx_parameters["nonce"],
data=tx_parameters.get("data"),
gas_price=tx_parameters.get("gasPrice"),
max_priority_fee_per_gas=tx_parameters.get("maxPriorityFeePerGas"),
max_fee_per_gas=tx_parameters.get("maxFeePerGas"),
chain_id=chain_id,
Expand Down
29 changes: 29 additions & 0 deletions tests/test_hw_wallet_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,3 +213,32 @@ def test_execute(
self.assertIsNotNone(
self.ethereum_client.w3.eth.get_transaction_receipt(tx_hash)
)

@mock.patch(
"safe_cli.operators.hw_wallets.ledger_wallet.create_transaction", autospec=True
)
def test_ledger_signs_gas_price(self, mock_create_transaction: MagicMock):
ledger_wallet = LedgerWallet.__new__(LedgerWallet)
ledger_wallet.derivation_path = "44'/60'/0'/0"
ledger_wallet.dongle = None
mock_create_transaction.return_value.raw_transaction.return_value = "0x00"
transaction = {
"to": Account.create().address,
"value": 1,
"gas": 21000,
"nonce": 3,
}
ledger_wallet.get_signed_raw_transaction(
{**transaction, "gasPrice": 25 * 10**9}, 1337
)
kwargs = mock_create_transaction.call_args.kwargs
self.assertEqual(kwargs["gas_price"], 25 * 10**9)
self.assertIsNone(kwargs["max_fee_per_gas"])

ledger_wallet.get_signed_raw_transaction(
{**transaction, "maxFeePerGas": 30 * 10**9, "maxPriorityFeePerGas": 1},
1337,
)
kwargs = mock_create_transaction.call_args.kwargs
self.assertIsNone(kwargs["gas_price"])
self.assertEqual(kwargs["max_fee_per_gas"], 30 * 10**9)
Loading