Repository navigation
Add Safe v1.5.0 canonical addresses - #8
Closed
techdigger wants to merge 1 commit into
Closed
techdigger wants to merge 1 commit into
techdigger wants to merge 1 commit into
Conversation
safe_addresses.py lists contracts up to v1.4.1. On a network that has only v1.5.0, the attended mode finds no singleton and no fallback handler and fails at startup with "Network ... is not supported". Add the v1.5.0 canonical addresses from safe-deployments, last in each list. safe-cli takes the first address that has code, so a network with an earlier version behaves as before and a network with only v1.5.0 works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the v1.5.0 canonical addresses from safe-deployments to each list in
safe_addresses.py: Safe, SafeL2, CompatibilityFallbackHandler, SafeProxyFactory, MultiSend, MultiSendCallOnly and SignMessageLib.Each goes last in its list. safe-cli takes the first address that has code, so:
Why
The lists stop at v1.4.1. On a network that has only v1.5.0, the attended mode finds no singleton and no fallback handler, and fails at startup with
ValueError: Network ... is not supported. Hardware wallets,approve_hashand owner management all need the attended mode.Listing v1.5.0 first would change more than that. On each network that has v1.5.0, Ethereum mainnet included:
safe-creatorwould create v1.5.0 Safes by default;updatewould move pre-1.3.0 Safes straight to v1.5.0;This PR leaves that choice to the maintainers.
Tested
A new test checks all seven lists in both cases: only v1.5.0 deployed, and every version deployed.
On a forked chain with only the v1.5.0 contracts:
approve_hash,add_owner,change_thresholdandsend_ethergo through;safe-creatorcreates a 2-of-3 v1.5.0 SafeL2 through the v1.5.0 factory;getTransactionHash.Generated by Claude Code