fix: validate node type and drop dead vars in init-bedrock - #93
Open
Alicepoltora wants to merge 1 commit into
Open
Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
- Reject unknown NODE_TYPE values early. Previously a typo such as NODE_TYPE=ful silently fell through and synced from genesis as a full node instead of failing. - Require BEDROCK_DATADIR to be set with a clear error instead of failing later inside extract with an empty datadir. - Remove the unused TORRENTS_DIR and BEDROCK_TMP_PATH variables and initialize BEDROCK_TAR_DOWNLOAD so the download block never reads an unset variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unknown NODE_TYPE values early: previously a typo such as NODE_TYPE=ful silently fell through and synced from genesis as a full node instead of failing. Also require BEDROCK_DATADIR to be set with a clear error, remove the unused TORRENTS_DIR and BEDROCK_TMP_PATH variables, and initialize BEDROCK_TAR_DOWNLOAD so the download block never reads an unset variable. Verified with bash -n plus behavioral tests of the validation branches.