Skip to content

fix: validate node type and drop dead vars in init-bedrock #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alicepoltora wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate node type and drop dead vars in init-bedrock #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions scripts/init-bedrock.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ source ./scripts/utils.sh
# Common variables.
INITIALIZED_FLAG=/shared/initialized.txt
BEDROCK_JWT_PATH=/shared/jwt.txt
GETH_DATA_DIR=$BEDROCK_DATADIR
TORRENTS_DIR=/torrents/$NETWORK_NAME
: "${BEDROCK_DATADIR:?BEDROCK_DATADIR is not set (expected from envs/<network>/op-geth.env)}"
GETH_DATA_DIR="$BEDROCK_DATADIR"
BEDROCK_TAR_PATH=/downloads/bedrock.tar
BEDROCK_TAR_CHECKSUM_PATH=
BEDROCK_TMP_PATH=/bedrock-tmp
BEDROCK_TAR_DOWNLOAD=""

function validate_snapshot_filename() {
local snapshot_filename="$1"
Expand Down Expand Up @@ -71,6 +71,14 @@ fi
echo "Bedrock node needs to be initialized..."
echo "Initializing via download..."

# Fail fast on an unknown node type: without this, a typo such as
# NODE_TYPE=ful would silently fall through and sync from genesis as a
# full node.
if [ "$NODE_TYPE" != "archive" ] && [ "$NODE_TYPE" != "full" ]; then
echo "Unsupported node type: $NODE_TYPE (expected 'full' or 'archive')" >&2
exit 1
fi

# Resolve the latest archival geth datadir snapshot from the ChainSnap indexes.
echo "Fetching download link..."

Expand Down