ci: migrate coverage badge from self-hosted SVG to Codecov - #137
Merged
Conversation
The coverage job previously generated a badge SVG and pushed it directly to master/develop with a contents:write token. Now that master requires PRs and disallows direct pushes, that push no longer fits the branch protection policy. Upload coverage to Codecov instead, which serves the badge itself and needs no git push, letting the job run with contents:read.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coveragejob used to generate a badge SVG andgit pushit directly tomaster/developwith acontents: writetoken, which conflicts with the branch-protection policy that now requires PRs and disallows direct pushes tomaster.codecov/codecov-action@v5, so coverage is uploaded to Codecov instead of being pushed back into the repo. The job's permission is reduced tocontents: read.vitest.config.tscoverage reporter fromjson-summary(only used for the old badge script) tolcov(auto-detected by Codecov)..github/badges/coverage.svg.Test plan
npm run test:coveragelocally confirmscoverage/lcov.infoandcoverage/index.htmlare generatednpm run lintpassesCODECOV_TOKENrepo secret is already configured; confirm thecoveragejob succeeds and uploads to Codecov after this merges