Conversation
graph() caches the built graph per context so repeated runs skip re-evaluating every node's flag. The build also created the graph's track data, run id included, so every run for the same context reported the same runId on its $ld:ai:graph:* events. Each run now copies the cached track data with a fresh runId and passes it to route and stream_route through their opts, so the node, handoff and graph-level events of one run share one id and the next run gets another. The flag evaluations stay cached.
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 12ad1ff. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running the same
graph()twice for the same context reported both runs under one run id, so separate runs looked like one in the$ld:ai:graph:*events.graph()caches the built graph per context so it doesn't re-evaluate every node's flag on each call. The run id was created in that build, so it was cached too. Each run now gets a fresh id. Every graph event within a run still shares it, and the flag evaluations stay cached.JS twin: launchdarkly/js-ai-sdk#109. Source branch:
fix/graph-run-id-per-run.Testing
test_graph_stream.py, for bothinvokeandstream: two runs on onegraph()instance and context get different ids, and all graph events in a run (node, handoff, success) share one. It fails on main.Note
Overview
Fixes duplicate
runIdacross separategraph()runs when the same instance and LD context reuse the cached graph build.Each
invoke/streamnow merges the cached build track payload with a new UUIDrunId, passes that copy on route options via_run_track_data, and uses it for handoff success/failure events inside the cached closures so analytics still group node, handoff, and invocation events per run without rebuilding the graph.Adds
TestGraphRunId(invoke + stream): two runs on onegraph()share one id within a run and get different ids across runs.Reviewed by Cursor Bugbot for commit 12ad1ff. Bugbot is set up for automated code reviews on this repo. Configure here.