Skip to content

fix(client): give each graph() run its own run id #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apucacao wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(client): give each graph() run its own run id #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions packages/client/src/launchdarkly_ai_server/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
MAX_TRAVERSAL_DEPTH = 100
MAX_GRAPH_CACHE_SIZE = 512

# graph() caches a built graph per context, track data included. Each run passes its own copy
# with a fresh runId through route/stream_route opts under this key, so the handoff events
# emitted inside the cached build carry the run's id instead of the build's.
_RUN_TRACK_DATA = "_run_track_data"


def _sanitize_name(key: str) -> str:
# Match TS sanitizeName: hyphens become underscores (tool names must be [a-zA-Z0-9_]).
Expand Down Expand Up @@ -259,7 +264,7 @@ async def run_node(
"$ld:ai:graph:handoff_success",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": from_node.key,
"targetKey": node.key,
},
Expand All @@ -277,7 +282,7 @@ async def run_node(
"$ld:ai:graph:handoff_failure",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": from_node.key,
"targetKey": node.key,
},
Expand Down Expand Up @@ -435,7 +440,7 @@ async def route(
"$ld:ai:graph:handoff_success",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": node.key,
"targetKey": next_node.key,
},
Expand All @@ -455,7 +460,7 @@ async def route(
"$ld:ai:graph:handoff_failure",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": node.key,
"targetKey": chosen_key,
},
Expand Down Expand Up @@ -551,7 +556,7 @@ async def stream_node(
"$ld:ai:graph:handoff_success",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": from_node.key,
"targetKey": node.key,
},
Expand Down Expand Up @@ -580,7 +585,7 @@ async def stream_node(
"$ld:ai:graph:handoff_failure",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": from_node.key,
"targetKey": node.key,
},
Expand Down Expand Up @@ -694,7 +699,7 @@ async def stream_route(
"$ld:ai:graph:handoff_success",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": node.key,
"targetKey": next_node.key,
},
Expand Down Expand Up @@ -725,7 +730,7 @@ async def stream_route(
"$ld:ai:graph:handoff_failure",
ld_ctx,
{
**graph_track_data,
**opts.get(_RUN_TRACK_DATA, graph_track_data),
"sourceKey": node.key,
"targetKey": chosen_key,
},
Expand Down Expand Up @@ -907,11 +912,13 @@ async def invoke(
# Evict an arbitrary entry to keep the cache bounded.
self._cache.pop(next(iter(self._cache)))
self._cache[cache_key] = built
graph_def, graph_track_data, _ = built
graph_def, built_track_data, _ = built

if not graph_def.enabled:
raise ValueError(f'Agent graph "{self._key}" is disabled')

graph_track_data: TrackData = {**built_track_data, "runId": str(uuid.uuid4())}

tracer = trace.get_tracer("@launchdarkly/ai-server")
with tracer.start_as_current_span("launchdarkly.graph") as span:
span.set_attribute("launchdarkly.graph.key", self._key)
Expand Down Expand Up @@ -944,7 +951,10 @@ async def invoke(
1,
)
entered += 1
opts: dict[str, Any] = {"variables": variables}
opts: dict[str, Any] = {
"variables": variables,
_RUN_TRACK_DATA: graph_track_data,
}
if previous_node:
opts["from"] = previous_node
# History seeds the entry point only. After the root hop, nodes
Expand Down Expand Up @@ -1123,11 +1133,13 @@ async def _stream_events(
if len(self._cache) >= MAX_GRAPH_CACHE_SIZE:
self._cache.pop(next(iter(self._cache)))
self._cache[cache_key] = built
graph_def, graph_track_data, stream_route = built
graph_def, built_track_data, stream_route = built

if not graph_def.enabled:
raise ValueError(f'Agent graph "{self._key}" is disabled')

graph_track_data: TrackData = {**built_track_data, "runId": str(uuid.uuid4())}

tracer = trace.get_tracer("@launchdarkly/ai-server")
span = tracer.start_span("launchdarkly.graph", context=caller_context)
span.set_attribute("launchdarkly.graph.key", self._key)
Expand Down Expand Up @@ -1161,7 +1173,10 @@ async def _stream_events(
1,
)
entered += 1
route_opts: dict[str, Any] = {"variables": variables}
route_opts: dict[str, Any] = {
"variables": variables,
_RUN_TRACK_DATA: graph_track_data,
}
if previous_node:
route_opts["from"] = previous_node
# History seeds the entry point only. After the root hop, nodes
Expand Down
30 changes: 30 additions & 0 deletions packages/client/tests/test_graph_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,36 @@ async def invoke_fn(
# ---------------------------------------------------------------------------


class TestGraphRunId:
@pytest.mark.parametrize("mode", ["invoke", "stream"])
async def test_each_run_gets_its_own_run_id(
self, mock_ld_client: MagicMock, mode: str
) -> None:
"""One graph() instance, one context, two runs: one id per run, shared within it."""
g = graph("graph-key", handlers=[_make_streaming_handler(["ok"])])

run_ids: list[set[str]] = []
for _ in range(2):
mock_ld_client.track.reset_mock()
if mode == "invoke":
await g.invoke("hi", CONTEXT)
else:
await _collect(g.stream("hi", CONTEXT))
graph_events = [
c[0]
for c in mock_ld_client.track.call_args_list
if c[0][0].startswith("$ld:ai:graph:")
]
names = {e[0] for e in graph_events}
assert "$ld:ai:graph:handoff_success" in names
assert "$ld:ai:graph:invocation_success" in names
run_ids.append({e[2]["runId"] for e in graph_events})

assert len(run_ids[0]) == 1
assert len(run_ids[1]) == 1
assert run_ids[0] != run_ids[1]


class TestGraphStreamOtel:
async def test_stamps_conversation_id_when_bound_at_call_time(
self, mock_ld_client: MagicMock
Expand Down
Loading