Skip to content

chore: Assert readiness directly instead of waiting on a timeout - #532

Merged
jsonbailey merged 1 commit into
mainfrom
jb/ready-assertions
Sep 30, 2026
Merged

jsonbailey merged 1 commit into
mainfrom
jb/ready-assertions

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

assert not ready.wait(0.1) cannot tell a correct refusal to signal from a slow machine, so these three tests read the flag directly instead.


Note

Overview
Three datasource tests that expect initialization not to complete now assert not ready.is_set() instead of not ready.wait(0.1).

That removes a timing dependency: a short Event.wait could return false on a slow CI host even when readiness was correctly withheld, which made these negative assertions flaky. Behavior under test is unchanged—only how the tests observe the readiness flag.

Reviewed by Cursor Bugbot for commit 58dda63. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey requested a review from a team as a code owner September 29, 2026 19:44
@jsonbailey
jsonbailey merged commit 4d75813 into main Sep 30, 2026
28 of 29 checks passed
@jsonbailey
jsonbailey deleted the jb/ready-assertions branch September 30, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants