Skip to content

chore: Assert readiness directly instead of waiting on a timeout #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 1 commit into from
Sep 30, 2026
Merged

chore: Assert readiness directly instead of waiting on a timeout #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ldclient/testing/impl/datasource/test_polling_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def test_unexpected_http_error_moves_to_the_extended_regime(ignore_mock):

# The extended regime starts at five minutes, so only the first poll runs.
wait_until(lambda: retry.next_delay > 0.1)
assert not ready.wait(0.1)
assert not ready.is_set()
assert mock_requester.request_count == 1


Expand Down
4 changes: 2 additions & 2 deletions ldclient/testing/impl/datasource/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def test_unexpected_http_error_backs_off_a_long_way(status):
wait_until(lambda: sp._retry.next_delay > NORMAL_STREAMING_CEILING_DELAY)

# Initialization is not falsely unblocked.
assert not ready.wait(0.1)
assert not ready.is_set()
assert not sp.initialized()
assert sp.is_alive()
server.should_have_requests(1)
Expand Down Expand Up @@ -927,7 +927,7 @@ def test_failure_transitions_from_valid():
wait_until(lambda: len(spy.statuses) == 2)

# The 401 is retried five minutes out, so readiness never fires.
assert not ready.wait(0.1)
assert not ready.is_set()
server.should_have_requests(1)

assert len(spy.statuses) == 2
Expand Down
Loading