Skip to content

chore(pinact): pin/update GitHub Actions - #1035

Open
davidliu wants to merge 1 commit into
mainfrom
ci/pinact_action
Open

davidliu wants to merge 1 commit into
mainfrom
ci/pinact_action

Conversation

@davidliu

@davidliu davidliu commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Automated update by pinact.

@changeset-bot

changeset-bot Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 757ab24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@davidliu
davidliu force-pushed the ci/pinact_action branch 2 times, most recently from 8004dd7 to 65f462b Compare October 19, 2026 00:24
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Diffuse output:

Base AAR cache miss. Please run the build job on main to generate the base AAR.

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

Devin Review found 1 new potential issue.

Devin Review

uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Each Java setup step passes adopt to actions/setup-java v6, which no longer supports that distribution. Setup fails before the CI, dependency-diff, and publishing jobs reach Gradle.

Learn more

actions/setup-java v6 removed the adopt distribution alias. Its distribution factory returns no installer for that value, so each affected setup step fails before any later Gradle command runs. The same value appears in both Java setup steps in the Android workflow and in the changesets, dependency-diff, and manual-release workflows.

Example: A pull request starts the Android CI build job. The Java setup step requests adopt, fails to find a supported distribution, and never runs the SDK tests.

Recommended fix: Set distribution: 'temurin' at all five Java setup steps, keeping the pinned v6 action.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@davidliu
davidliu force-pushed the ci/pinact_action branch 3 times, most recently from f8f5b7f to 9108bc8 Compare November 3, 2026 01:44

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

3 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review


- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Every upgraded setup-java invocation still selects adopt, which v6 no longer supports. Java setup fails before Gradle runs. Android CI, dependency diffs, Diffuse checks, and both release workflows are blocked.

Learn more

The pinned setup-java v6.1.0 implementation removes the adopt, adopt-hotspot, and adopt-openj9 distribution handlers. Every updated invocation retains distribution: adopt, so each fails during Java setup. The affected jobs are Android build and Diffuse, dependency diff, automated Maven publishing, and manual publishing.

Example: An ordinary pull request starts Android CI, but Java setup rejects adopt and never reaches the Gradle build or tests.

Recommended fix: Change all five updated setup-java invocations to distribution: temurin while retaining Java 17, or retain the previous action pin until the distribution migration is included.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

- name: Create Release Pull Request
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release action rejects installed CLI

changesets/action v2 rejects CLI v2 before processing releases. The CLI dependency remains ^2.27.7, so every release-action invocation fails.

Learn more

The pinned action calls validateChangesetsCliVersion before processing inputs or changesets. That validator rejects both a declared CLI v2 dependency range and an installed CLI v2 package. The repository declares @changesets/cli: ^2.27.7 in its development dependencies, which cannot resolve to v3.

Example: A push to main installs CLI v2, then the release action fails with its CLI compatibility error instead of creating or publishing a release.

Recommended fix: Keep changesets/action on its previous v1 pin, or migrate the CLI dependency, lockfile, configuration, and custom release scripts to the v3 contract before upgrading the action.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

- name: Create Release Pull Request
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Removed release inputs abort automation

After CLI compatibility is resolved, changesets/action rejects the retained title, commit, version, and publish inputs. Its throwOnRenamedInputs guard aborts before versioning or publishing.

Learn more

The pinned action does not silently accept the old input names: throwOnRenamedInputs raises an error when any has a nonempty value. All four configured inputs use removed names. The custom version command also updates Android version metadata through ci:version, so preserving that command matters during migration.

Example: With a compatible CLI installed, a release run fails reporting the renamed inputs instead of executing pnpm ci:version.

Recommended fix: Rename title to pr-title, commit to commit-message, version to version-script, and publish to publish-script, preserving their values. Alternatively, retain the v1 action pin.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant