Repository navigation
chore(pinact): pin/update GitHub Actions #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ jobs: | |
| submodules: recursive | ||
|
|
||
| - name: set up JDK 17 | ||
| uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0 | ||
| uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'adopt' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Unsupported Java distribution blocks builds and releases Each Java setup step passes Learn more
Example: A pull request starts the Android CI build job. The Java setup step requests Recommended fix: Set Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
@@ -68,7 +68,7 @@ jobs: | |
| run: ./gradlew livekit-android-sdk:detektRelease | ||
|
|
||
| - name: Upload AAR | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 | ||
| with: | ||
| name: livekit-android-sdk-release.aar | ||
| path: client-sdk-android/livekit-android-sdk/build/outputs/aar/livekit-android-sdk-release.aar | ||
|
|
@@ -252,7 +252,7 @@ jobs: | |
| name: Diffuse checker | ||
| needs: [build, diffuse_prep] | ||
| steps: | ||
| - uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0 | ||
| - uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'adopt' | ||
|
|
@@ -264,7 +264,7 @@ jobs: | |
| path: client-sdk-android/diffuse-source-file | ||
| key: diffuse-${{ github.event.pull_request.base.sha }} | ||
|
|
||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2 | ||
| name: Download current release AAR for diffuse | ||
| with: | ||
| name: livekit-android-sdk-release.aar | ||
|
|
@@ -302,7 +302,7 @@ jobs: | |
| issue-number: ${{ github.event.pull_request.number }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| - uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 | ||
| with: | ||
| name: diffuse-output | ||
| path: ${{ steps.diffuse.outputs.diff-file }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,12 +21,12 @@ jobs: | |
| - name: Checkout Repo | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
|
||
| - uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10 | ||
| - uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 | ||
| with: | ||
| version: 10 | ||
|
|
||
| - name: Use Node.js 24 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version: 24 | ||
| cache: "pnpm" | ||
|
|
@@ -46,7 +46,7 @@ jobs: | |
|
|
||
| - name: Create Release Pull Request | ||
| id: changesets | ||
| uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0 | ||
| uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Release action rejects installed CLI
Learn moreThe pinned action calls Example: A push to main installs CLI v2, then the release action fails with its CLI compatibility error instead of creating or publishing a release. Recommended fix: Keep changesets/action on its previous v1 pin, or migrate the CLI dependency, lockfile, configuration, and custom release scripts to the v3 contract before upgrading the action. Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Removed release inputs abort automation After CLI compatibility is resolved, Learn moreThe pinned action does not silently accept the old input names: Example: With a compatible CLI installed, a release run fails reporting the renamed inputs instead of executing Recommended fix: Rename Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| with: | ||
| title: ${{ steps.getver.outputs.TITLE }} | ||
| commit: ${{ steps.getver.outputs.TITLE }} | ||
|
|
@@ -85,7 +85,7 @@ jobs: | |
| submodules: recursive | ||
|
|
||
| - name: set up JDK 17 | ||
| uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0 | ||
| uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'adopt' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Unsupported Java distribution blocks builds and releases
Every upgraded
setup-javainvocation still selectsadopt, which v6 no longer supports. Java setup fails before Gradle runs. Android CI, dependency diffs, Diffuse checks, and both release workflows are blocked.Learn more
The pinned setup-java v6.1.0 implementation removes the
adopt,adopt-hotspot, andadopt-openj9distribution handlers. Every updated invocation retainsdistribution: adopt, so each fails during Java setup. The affected jobs are Android build and Diffuse, dependency diff, automated Maven publishing, and manual publishing.Example: An ordinary pull request starts Android CI, but Java setup rejects
adoptand never reaches the Gradle build or tests.Recommended fix: Change all five updated setup-java invocations to
distribution: temurinwhile retaining Java 17, or retain the previous action pin until the distribution migration is included.Was this helpful? React with 👍 or 👎 to provide feedback.