Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Every upgraded setup-java invocation still selects adopt, which v6 no longer supports. Java setup fails before Gradle runs. Android CI, dependency diffs, Diffuse checks, and both release workflows are blocked.

Learn more

The pinned setup-java v6.1.0 implementation removes the adopt, adopt-hotspot, and adopt-openj9 distribution handlers. Every updated invocation retains distribution: adopt, so each fails during Java setup. The affected jobs are Android build and Diffuse, dependency diff, automated Maven publishing, and manual publishing.

Example: An ordinary pull request starts Android CI, but Java setup rejects adopt and never reaches the Gradle build or tests.

Recommended fix: Change all five updated setup-java invocations to distribution: temurin while retaining Java 17, or retain the previous action pin until the distribution migration is included.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

with:
java-version: '17'
distribution: 'adopt'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Each Java setup step passes adopt to actions/setup-java v6, which no longer supports that distribution. Setup fails before the CI, dependency-diff, and publishing jobs reach Gradle.

Learn more

actions/setup-java v6 removed the adopt distribution alias. Its distribution factory returns no installer for that value, so each affected setup step fails before any later Gradle command runs. The same value appears in both Java setup steps in the Android workflow and in the changesets, dependency-diff, and manual-release workflows.

Example: A pull request starts the Android CI build job. The Java setup step requests adopt, fails to find a supported distribution, and never runs the SDK tests.

Recommended fix: Set distribution: 'temurin' at all five Java setup steps, keeping the pinned v6 action.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
run: ./gradlew livekit-android-sdk:detektRelease

- name: Upload AAR
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: livekit-android-sdk-release.aar
path: client-sdk-android/livekit-android-sdk/build/outputs/aar/livekit-android-sdk-release.aar
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:
name: Diffuse checker
needs: [build, diffuse_prep]
steps:
- uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
- uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0
with:
java-version: '17'
distribution: 'adopt'
Expand All @@ -264,7 +264,7 @@ jobs:
path: client-sdk-android/diffuse-source-file
key: diffuse-${{ github.event.pull_request.base.sha }}

- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
- uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
name: Download current release AAR for diffuse
with:
name: livekit-android-sdk-release.aar
Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:
issue-number: ${{ github.event.pull_request.number }}
token: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
- uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: diffuse-output
path: ${{ steps.diffuse.outputs.diff-file }}
8 changes: 4 additions & 4 deletions .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10
- uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0
with:
version: 10

- name: Use Node.js 24
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: 24
cache: "pnpm"
Expand All @@ -46,7 +46,7 @@ jobs:

- name: Create Release Pull Request
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release action rejects installed CLI

changesets/action v2 rejects CLI v2 before processing releases. The CLI dependency remains ^2.27.7, so every release-action invocation fails.

Learn more

The pinned action calls validateChangesetsCliVersion before processing inputs or changesets. That validator rejects both a declared CLI v2 dependency range and an installed CLI v2 package. The repository declares @changesets/cli: ^2.27.7 in its development dependencies, which cannot resolve to v3.

Example: A push to main installs CLI v2, then the release action fails with its CLI compatibility error instead of creating or publishing a release.

Recommended fix: Keep changesets/action on its previous v1 pin, or migrate the CLI dependency, lockfile, configuration, and custom release scripts to the v3 contract before upgrading the action.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Removed release inputs abort automation

After CLI compatibility is resolved, changesets/action rejects the retained title, commit, version, and publish inputs. Its throwOnRenamedInputs guard aborts before versioning or publishing.

Learn more

The pinned action does not silently accept the old input names: throwOnRenamedInputs raises an error when any has a nonempty value. All four configured inputs use removed names. The custom version command also updates Android version metadata through ci:version, so preserving that command matters during migration.

Example: With a compatible CLI installed, a release run fails reporting the renamed inputs instead of executing pnpm ci:version.

Recommended fix: Rename title to pr-title, commit to commit-message, version to version-script, and publish to publish-script, preserving their values. Alternatively, retain the v1 action pin.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

with:
title: ${{ steps.getver.outputs.TITLE }}
commit: ${{ steps.getver.outputs.TITLE }}
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0
with:
java-version: '17'
distribution: 'adopt'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/dependency_diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ jobs:
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
- uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0
with:
distribution: 'adopt'
java-version: 17

- uses: gradle/actions/setup-gradle@9c971963bec38e04b3d30dcc455b5382be2fdbfb # v6.3.0
- uses: gradle/actions/setup-gradle@3f5f9adaf7d9fecd50b5935e54106014257a94e6 # v6.4.0

- id: dependency-diff
name: Generate dependency diff
uses: usefulness/dependency-tree-diff-action@a9b2aa1567cc3b9c860c373479a24dc60429bfda # v2.3.0
uses: usefulness/dependency-tree-diff-action@ff9888adef68e2c4117884a13d36c7fe390b698b # v2.4.0
with:
project: 'livekit-android-sdk'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pinact_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Install aqua (installs pinact)
uses: aquaproj/aqua-installer@96a9bc20066c5bf5e275b41019cfc165b25f4e2e # v4.0.5
uses: aquaproj/aqua-installer@82d0e83878a8657c4a6f2ff1755d3bfbfc67f329 # v4.1.0
with:
aqua_version: v2.56.1
aqua_opts: "-c aqua.yaml"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6.1.0
with:
java-version: '17'
distribution: 'adopt'
Expand Down
Loading