Repository navigation
fix(interrogate): take every lens whose trigger matches, not only for SDKs - #23
Merged
Merged
Conversation
… SDKs PR #22 forced Exposure, Isolation, and Upgrade on SDK and package changes. That restated the lenses' own triggers by artifact type and missed the same bugs in services, such as a Django worker with shared state. Frame now takes every lens whose "Use when" the change meets, and Upgrade triggers on any outside consumer: a package, public API, CLI, or a schema others read. Tested: bun scripts/check-port.ts -> 0 findings.
Gate findings on a4eea2e. blind-spots.md still said the lead picks lenses, contradicting the new rule; it now defers to Frame. With matching lenses mandatory, Exposure's "run every path that writes to the destination" meant canary-testing every endpoint for a one-field response change. It now covers values the change adds or reshapes, the paths it alters, and new values that skip redaction their payload neighbors get. Tested: bun scripts/check-port.ts -> 0 findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal is a pre-PR gate that catches the bugs review bots keep finding, wherever those bugs can happen. #22 forced Exposure, Isolation, and Upgrade onto SDK and package changes only. That repeated the lenses' own triggers as a check on artifact type, and it missed the same bugs in services, such as a Django worker with shared state.
What changed
Scope
Blast Radius
More gate runs carry more lenses, so adversaries spend more per run. Exposure's narrower method offsets part of that.
Verification
bun scripts/check-port.tsreports 0 findings.