Repository navigation
ED2208: end the BUSY wait at the first high - #357
Merged
Merged
Conversation
_wait_busy() treated BUSY as released only after it stayed high for 200 ms, assuming a short high between the steps of the AUTO sequence, and right after a refresh started it required the 200 ms even when BUSY was already high. Recording BUSY and CS edges with GPIO interrupts on a PaperColor showed BUSY goes low while the last byte of AUTO is being received and stays low for the whole sequence (POWER_ON, DISPLAY_REFRESH, POWER_OFF) with no short high, also on the first refresh after power-on and with 6-color and dithered images. The confirmation only delayed every wait by 200 ms (display() took about 1.33 s instead of 1.12 s). The wait now ends when displayBusy() turns false, which also covers boards without a BUSY pin. Without a reset pin the next refresh is started within about 1 ms of BUSY going high; three consecutive refreshes completed that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panel_ED2208::_wait_busy()treated BUSY as released only after it stayed high for 200 ms, assuming a short high between the steps of the AUTO sequence; right after a refresh started it required the 200 ms even when BUSY was already high. The wait now ends at the first high (displayBusy()turns false), which also covers boards without a BUSY pin.Measurements (PaperColor, room temperature)
BUSY and CS edges were recorded with GPIO interrupts (µs timestamps):
display()takes about 1.12 s instead of 1.33 s (the 200 ms is no longer added to the wait for the previous refresh).Testing